This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: rs6000 patch for logical operation cleanup.
- To: dje at watson dot ibm dot com
- Subject: Re: rs6000 patch for logical operation cleanup.
- From: Geoff Keating <geoffk at cygnus dot com>
- Date: Fri, 19 May 2000 11:10:33 -0700
- CC: gcc-patches at gcc dot gnu dot org, gcc-bugs at gcc dot gnu dot org
- References: <200005191749.NAA22380@mal-ach.watson.ibm.com>
> cc: gcc-patches@gcc.gnu.org, gcc-bugs@gcc.gnu.org
> Date: Fri, 19 May 2000 13:49:03 -0400
> From: David Edelsohn <dje@watson.ibm.com>
> How can we solve this once and for all so that it is not reverted
> again?
by writing something like
if (HOST_BITS_PER_WIDE_INT < GET_MODE_SIZE (mode)
&& INTVAL (x) < 0)
return 0;
and _adding the testcase_ so that when in future someone changes this
code, and gets it wrong, they know about it. This is the only
guaranteed way to fix a bug.
--
- Geoffrey Keating <geoffk@cygnus.com>