This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch, fortran] Fix PR 84394
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 15 Mar 2019 13:31:20 -0700
- Subject: Re: [patch, fortran] Fix PR 84394
- References: <503927ab-ac48-bd34-1e74-d38b63d31750@netcologne.de>
- Reply-to: sgk at troutmask dot apl dot washington dot edu
On Fri, Mar 15, 2019 at 07:55:51PM +0100, Thomas Koenig wrote:
> Hello world,
>
> this patch fixes a rejects-valid 7/8/9 regression where subroutines like
> _deallocate are added to a derived type in a block data, and because
> they were marked PRIVATE, an error occurred.
>
> This solution is look for this particular case by checking for an
> underscore as the first letter of the subroutine name. This can only
> occur for compiler-generated subroutines, so this should be safe.
> I have also restricted this to the particular case of a BLOCK DATA
> as not to mask other potential errors.
>
> This is not elegant, but effecive...
>
> Regression-tested.
>
> Ok for trunk and backport?
>
Patch is missing?
--
Steve