This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, fortran] PR66679 - [OOP] ICE with class(*) and transfer
- From: Janus Weil <janus at gcc dot gnu dot org>
- To: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Miha Polajnar <polajnar dot miha at gmail dot com>
- Date: Mon, 23 Jul 2018 22:20:15 +0200
- Subject: Re: [Patch, fortran] PR66679 - [OOP] ICE with class(*) and transfer
- References: <CAGkQGiLnxPGo5=6v-8gs3PaYJVnDpJ19Q0GRnb462gkwnyUqOg@mail.gmail.com> <CAGkQGi+Q+UMw7Z0mG-iuX63-sq1Gci=KcMYSHx+xCQKYb2V=JA@mail.gmail.com>
Hi Paul,
2018-07-23 17:51 GMT+02:00 Paul Richard Thomas <paul.richard.thomas@gmail.com>:
> Ping!
> On Thu, 5 Jul 2018 at 08:51, Paul Richard Thomas
> <paul.richard.thomas@gmail.com> wrote:
>>
>> The comment in the patch says it all.
>>
>> Bootstrapped and regtested on FC28/x86_64 - OK for trunk?
I don't see anything wrong with the patch, so as far as I'm concerned
it's ok for trunk.
Just one minor style-wise suggestion: I'd move the declaration of the
'class_expr' into the else branch where it's used (in order to have it
as locally as possible).
Thanks for the patch,
Janus
>> 2018-07-05 Paul Thomas <pault@gcc.gnu.org>
>>
>> PR fortran/66679
>> * trans-intrinsic.c (gfc_conv_intrinsic_transfer): Class array
>> elements are returned as references to the data element. Get
>> the class expression by stripping back the references. Use this
>> for the element size.
>>
>> 2018-07-05 Paul Thomas <pault@gcc.gnu.org>
>>
>> PR fortran/66679
>> * gfortran.dg/transfer_class_3.f90: New test.
>
>
>
> --
> "If you can't explain it simply, you don't understand it well enough"
> - Albert Einstein