This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
[gomp4] don't error on implicitly private induction variables in gfortran
- From: Cesar Philippidis <cesar at codesourcery dot com>
- To: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Fortran List <fortran at gcc dot gnu dot org>
- Date: Fri, 27 Jan 2017 07:02:45 -0800
- Subject: [gomp4] don't error on implicitly private induction variables in gfortran
- Authentication-results: sourceware.org; auth=none
While experimenting with some new OpenACC benchmarks, I noticed that
gfortran errors when the user explicitly marks loop induction variables
as private. I applied this patch to gomp-4_0-branch to resolve that problem.
Cesar
2017-01-26 Cesar Philippidis <cesar@codesourcery.com>
gcc/fortran/
* openmp.c (gfc_resolve_oacc_blocks): Populate list of private
variables.
gcc/testsuite/
* gfortran.dg/goacc/implicitly-private.f90: New test.
diff --git a/gcc/fortran/openmp.c b/gcc/fortran/openmp.c
index 61940d7..2782a8d 100644
--- a/gcc/fortran/openmp.c
+++ b/gcc/fortran/openmp.c
@@ -5192,7 +5192,8 @@ gfc_resolve_oacc_blocks (gfc_code *code, gfc_namespace *ns)
{
fortran_omp_context ctx;
oacc_function dims = OACC_FUNCTION_NONE;
-
+ gfc_omp_namelist *n;
+
resolve_oacc_loop_blocks (code);
ctx.code = code;
@@ -5217,6 +5218,10 @@ gfc_resolve_oacc_blocks (gfc_code *code, gfc_namespace *ns)
ctx.dims = dims;
omp_current_ctx = &ctx;
+ if (code->ext.omp_clauses)
+ for (n = code->ext.omp_clauses->lists[OMP_LIST_PRIVATE]; n; n = n->next)
+ ctx.private_iterators->add (n->sym);
+
gfc_resolve_blocks (code->block, ns);
omp_current_ctx = ctx.previous;
diff --git a/gcc/testsuite/gfortran.dg/goacc/implicitly-private.f90 b/gcc/testsuite/gfortran.dg/goacc/implicitly-private.f90
new file mode 100644
index 0000000..a687d8a
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/goacc/implicitly-private.f90
@@ -0,0 +1,12 @@
+! Ensure that implicitly private variables do not clash with those
+! that are explicitly private.
+
+program main
+ implicit none
+
+ integer i
+
+ !$acc parallel loop private(i)
+ do i = 1, 100
+ end do
+end program main