This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [libgfortran, patch] Rename numeric STOP runtime functions

From: FX <fxcoudert at gmail dot com>
To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
Cc: GCC-Fortran-ML <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 19 Dec 2016 17:18:53 +0100
Subject: Re: [libgfortran, patch] Rename numeric STOP runtime functions
Authentication-results: sourceware.org; auth=none
References: <E508CE7D-55E4-4C73-BC7F-A6A01B9B0B61@gmail.com> <CAO9iq9H2JAiXK+EPoMm_ScpiaveRtjnTKdotLUMgZGkbee++Fw@mail.gmail.com>

> The patch you posted contains some apparently unrelated changes to
> gfortran.map. Without those, Ok.

Thanks for the reviews. Patches committed. Wiki updated. I’ll work tonight on some of the remaining items on the “abi cleanup” list.


> As a minor cosmetic improvement, you could fold_convert the argument
> to integer_type_node instead of gfc_int4_type_node and change the
> library functions to take plain C int arguments, since the exit()
> argument is a C int anyways.

Then this would need to be done with coarray functions too, so I would not feel too comfortable. I’ll leave that as an improvement if there is agreement on that side.

FX

References:
- [libgfortran, patch] Rename numeric STOP runtime functions
  - From: FX
- Re: [libgfortran, patch] Rename numeric STOP runtime functions
  - From: Janne Blomqvist

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]