This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: *ping* [Patch, fortran, RFC] Add warning for missing location information
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: fortran at gcc dot gnu dot org
- Date: Sat, 3 Dec 2016 09:16:04 -0800
- Subject: Re: *ping* [Patch, fortran, RFC] Add warning for missing location information
- Authentication-results: sourceware.org; auth=none
- References: <4969b391-c8ec-4eb4-1cb7-d43d0013834d@netcologne.de> <e2c3c4d9-a939-308e-fc32-e532082fc8ba@netcologne.de>
On Mon, Nov 21, 2016 at 05:11:17PM +0100, Thomas Koenig wrote:
>
> > If something is found, a warning is issued. I chose not to issue an
> > error because missing location information does not make a program
> > invalid. The patch would cause testsuite regressions for changes
> > which cause missing location information, which is a good thing because
> > we want to catch missing locations as soon as they are (potentially)
> > introduced.
>
> > The checking is turned off if CHECKING_P is not defined, so it should
> > not slow down release compilers.
>
> > I used DK_NOTE here, but that is open to discussion. Maybe it would be
> > better to define another warning class for this?
>
> Ping? Any comments?
>
I see nothing wrong with the patch. Have you considered Janus's
questions?
--
Steve