Re: [PATCH, Fortran] DEC Compatibility: New I/O Specifiers CARRIAGECONTROL, READONLY, SHARE with -fdec

[Fritz Reese <fritzoreese at gmail dot com>]

On Tue, Oct 25, 2016 at 5:29 PM, Jerry DeLisle <jvdelisle@charter.net> wrote:
> On 10/25/2016 11:52 AM, Fritz Reese wrote:
>>
>> All,
>>
>> Here's the big one. This patch proposes an extension to both the GNU
>> Fortran front-end and runtime library (libgfortran) to support three
>> additional I/O specifiers: CARRIAGECONTROL, READONLY, and SHARE for
>> compatibility with legacy compilers/code.
...
>>
> I have started reviewing this. I assume you have tested on some if not all
> of your DEC code base. Have you compared results with ifort?

Yes, my original development process is to match outputs with the
version of ifort I have where it makes sense. I have compared the
CARRIAGECONTROL in particular quite extensively with ifort and it
gives the same output for inputs I can think of, which mostly comprise
of the ones in the DG tests. READONLY functions the same.

> How have you tested the SHARE feature? Do you have a test with multiple
> threads accessing a single file? or do I misunderstand that feature? (I
> don't mean in the testsuite, I mean as just your own testing.)

For SHARE, I had test programs open files with the various SHARE=
types and try to read/write them from separate processes (manually
through separate terminal windows), verifying that the locking occurs
according to the OS specs. I believe you understand correctly. I also
used 'strace' on those programs to verify the OS calls occured in the
correct order. Not sure how I could put such tests into DG so I didn't
bother.

Thanks again for all the help with the reviews.

---
Fritz Reese