This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch, fortran] PR77972 ICE on broken character continuation with -Wall etc.

From: Jerry DeLisle <jvdelisle at charter dot net>
To: fortran at gcc dot gnu dot org
Date: Fri, 14 Oct 2016 08:24:15 -0700
Subject: Re: [patch, fortran] PR77972 ICE on broken character continuation with -Wall etc.
Authentication-results: sourceware.org; auth=none
References: <1a598dbd-e1c1-9596-016c-9ba5a1791d89@charter.net> <20161014031844.GA21352@troutmask.apl.washington.edu>

On 10/13/2016 08:18 PM, Steve Kargl wrote:

On Thu, Oct 13, 2016 at 07:04:04PM -0700, Jerry DeLisle wrote:

This patch is straight forward. We were sending bogus locus info to the
diagnostics machinery and catch an assert in error,c.

The patch avoids doing this.

Regression tested on x86-64-linux.

OK for trunk?


Yes, but see below.

--- snip ---

               if (warn_ampersand && in_string == INSTRING_WARN)
                 gfc_warning (OPT_Wampersand,
                              "Missing %<&%> in continued character "


If this is a "missing '&' in a continued..." and the '&' is
required by the standard, then why is this just a warning?

A long time ago in a far away place we added the -Wampersand to appease theempire. ;) I do remember there was a lot of discussion on this so its basicallyan extension. We can revisit this some time perhaps.


Jerry

References:
- [patch, fortran] PR77972 ICE on broken character continuation with -Wall etc.
  - From: Jerry DeLisle
- Re: [patch, fortran] PR77972 ICE on broken character continuation with -Wall etc.
  - From: Steve Kargl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]