This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, fortran] Clean up of error recovery in DTIO procedures
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, Dominique Dhumieres <dominiq at lps dot ens dot fr>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 26 Sep 2016 13:17:25 +0200
- Subject: Re: [Patch, fortran] Clean up of error recovery in DTIO procedures
- Authentication-results: sourceware.org; auth=none
- References: <CAGkQGiLvUx05GgOfqRMwu2z6sQSJahYLP6S78iPVmThSi6siLA@mail.gmail.com> <yddy42iakds.fsf@CeBiTec.Uni-Bielefeld.DE> <CAGkQGiJrMdOXq3WSBZ58=q_EXJjJtCmOihYKmHFUAzD4-dvMiA@mail.gmail.com> <CAGkQGi+Xi+Xhp=ZbpCHbXZDoPdP1dnZ=SFEqXBhWk8sE25-27g@mail.gmail.com> <ydd8tuf9ihx.fsf@CeBiTec.Uni-Bielefeld.DE> <CAGkQGiK4ddAip57fGgh+OGvFTJ0g9OOb8O2ARPkd-G5cXfz8jA@mail.gmail.com> <CAGkQGi+tsAHiOtoPk-x5KLSZH=_a+d=2a+xC6+QVYCvsLTSYNg@mail.gmail.com> <CAGkQGiLSyA0rKwXUnnN7SictBZ9eO1HxNoNVR66cQ32zOsyMQQ@mail.gmail.com>
Dear Rainer and Dominique,
Committed as obvious in revision 240493.
Thanks for doing the testing.
Cheers
Paul
2016-09-26 Paul Thomas <pault@gcc.gnu.org>
PR fortran/48298
* interface.c (gfc_find_specific_dtio_proc) : Return NULL if
the derived type is broken, as indicated by a flavor other than
FL_DERIVED.
On 26 September 2016 at 10:26, Paul Richard Thomas
<paul.richard.thomas@gmail.com> wrote:
> Dear Rainer,
>
> Thanks to you and Dominique for the confirmation that the patch works. I
> will commit it sometime today.
>
> Regards
>
> Paul
>
>
> On 26 Sep 2016 10:23 a.m., "Rainer Orth" <ro@cebitec.uni-bielefeld.de>
> wrote:
>
> Hi Paul,
>
>> Dominique has informed me that the earlier patch did not fix this problem.
>
> indeed, it just shifted the SEGV to a different place.
>
>> Although I still cannot reproduce the problem on FC21, I think that I
>> can see what the problem is. The declared type of 'chairman' is
>> thoroughly broken when it arrives at
>> interface.c(gfc_find_specific_dtio_proc). It doesn't even have the
>> right name! The key signature is that its flavor is FL_UNKNOWN. The
>> attached prevents the code coming anywhere near the call that causes
>> the segfault and regtests OK.
>
> I've now managed to run a sparc-sun-solaris2.10 bootstrap with the patch
> included and the failures are gone indeed.
>
> Thanks.
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
--
The difference between genius and stupidity is; genius has its limits.
Albert Einstein