This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, Fortran] Fix PR 71902


Le 18/08/2016 à 21:24, Thomas Koenig a écrit :
Hello Mikael,

This doesn't look correct, what about substrings following component or
array references?

You're right; corrected in the attached patch.  I have also added a test
case for this.

PS: What about the original fix, wasn't it a dependency
problem/inaccuracy after all?

The main error was using the allocatable attribute on the symbol that
we were dealing with a deferred length.  Changing the test to check for
expr->ts.deferred is the right thing to do.

Seems sensible. However deferred length includes pointers as well, so I would still keep additionally the original test for allocatable-ness. Or even better replace it with gfc_expr_attr(expr1).allocatable.
OK with that change.
Thanks

Mikael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]