This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x3)

From: Chung-Lin Tang <cltang at codesourcery dot com>
To: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>, <fortran at gcc dot gnu dot org>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Thomas Schwinge <thomas at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>
Date: Wed, 13 Jul 2016 19:52:53 +0800
Subject: Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x3)
Authentication-results: sourceware.org; auth=none
References: <2b4f59d5-be38-2814-27bb-73aa7ffb4b8f@codesourcery.com> <F1E73865-ED59-4FFB-8EEA-D3CB26281745@gmail.com> <e2ad8868-fdda-de14-6c59-ad43c25e4d46@codesourcery.com> <7db676cf-e30d-f37c-d173-169b2d9eebf4@codesourcery.com>

Ping x3

On 06/21/2016 02:18 PM, Chung-Lin Tang wrote:

Ping x2

On 2016/6/7 08:03 PM, Chung-Lin Tang wrote:

Ping.

On 2016/5/11 02:57 AM, Bernhard Reutner-Fischer wrote:

On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang <cltang@codesourcery.com> wrote:

Hi, this patch resolves an ICE for Fortran when using the OpenACC
host_data directive.  Actually, rather than say resolve, it's more like
adjusting the front-end to same middle-end restrictions as C/C++,
namely that we only support pointers or arrays for host_data right now.

This patch contains a little bit of adjustments in
fortran/openmp.c:resolve_omp_clauses(),
and some testcase adjustments. This has been tested without regressions
for Fortran.

Is this okay for trunk?

Thanks,
Chung-Lin

2015-05-09  Chung-Lin Tang  <cltang@codesourcery.com>

	gcc/
	* fortran/openmp.c (resolve_omp_clauses): Adjust use_device clause
	handling to only allow pointers and arrays.


Fortran has it's own ChangeLog. The patch itself looks somewhat plausible to me, fwiw, but Jakub or a FE maintainer has the say.

Follow-Ups:
- Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x4)
  - From: Chung-Lin Tang

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]