This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, fortran] (4/5-regression) PR61831 side-effect deallocation of variable components)
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Dominique d'HumiÃres <dominiq at lps dot ens dot fr>
- Cc: Andre Vehreschild <vehre at gmx dot de>, Mikael Morin <mikael dot morin at sfr dot fr>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Fortran List <fortran at gcc dot gnu dot org>
- Date: Mon, 18 Jan 2016 13:48:43 +0100
- Subject: Re: [Patch, fortran] (4/5-regression) PR61831 side-effect deallocation of variable components)
- Authentication-results: sourceware.org; auth=none
- References: <CAGkQGi+AQoRxnLpu5wbs=_21yogVn+aLv1KGueoaKjjwV+PEog at mail dot gmail dot com> <20160117181412 dot 3f5bbe55 at vepi2> <CAGkQGiJsXuP18ixfY-7XxmZxQ5qMaxeoJt9N=T9beVf8pmTVfg at mail dot gmail dot com> <988402C5-5327-475F-B132-B90D712AAD2B at lps dot ens dot fr>
Hi Dominique,
Late or not, thanks for the feedback. I'll fix the right brace. More
worrying is the failure with -m32. I presume that the failure with
-O0/O1 is at runtime? If not, the correction of the missing right
brace is a mysterious trigger for a fault that is optimization
dependent.
Cheers
Paul
On 18 January 2016 at 12:05, Dominique d'HumiÃres <dominiq@lps.ens.fr> wrote:
> Dear Paul,
>
> Sorry for the late feedback. There is a missing right brace in gfortran.dg/derived_constructor_comps_6.f90. This is fixed by the obvious patch:
>
> --- ../5_clean/gcc/testsuite/gfortran.dg/derived_constructor_comps_6.f90 2016-01-17 19:27:04.000000000 +0100
> +++ gcc/testsuite/gfortran.dg/derived_constructor_comps_6.f90 2016-01-18 03:02:17.000000000 +0100
> @@ -1,5 +1,5 @@
> ! { dg-do run }
> -! { dg-additional-options "-fdump-tree-original"
> +! { dg-additional-options "-fdump-tree-original" }
> !
> ! PR fortran/61831
> ! The deallocation of components of array constructor elements
>
> However with this patch the test fails with -m32 and -O0/O1.
>
> TIA
>
> Dominique
>
>> Le 17 janv. 2016 Ã 18:37, Paul Richard Thomas <paul.richard.thomas@gmail.com> a Ãcrit :
>>
>> Dear Andre,
>>
>> Thanks for the very useful discussion. It cleared away one or two cobwebs!
>>
>> Committed as revision 232482.
>>
>> Now to see if it will apply to 4.9 branch.... This might be a step too
>> far, since all sorts of other prerequisites are not there. If it
>> doesn't go well, I will close the PR as a WONTFIX on 4.9.
>>
>> Cheers
>>
>> Paul
>
--
The difference between genius and stupidity is; genius has its limits.
Albert Einstein