This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [RFC diagnostics/fortran] Move gfc_warning (buffered) to the common diagnostics machinery
- From: Dodji Seketeli <dodji at redhat dot com>
- To: Manuel LÃpez-IbÃÃez <lopezibanez at gmail dot com>
- Cc: Tobias Burnus <burnus at net-b dot de>, FX <fxcoudert at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, gfortran <fortran at gcc dot gnu dot org>
- Date: Mon, 01 Dec 2014 09:22:13 +0100
- Subject: Re: [RFC diagnostics/fortran] Move gfc_warning (buffered) to the common diagnostics machinery
- Authentication-results: sourceware.org; auth=none
- References: <CAESRpQCGfALwFN_PgLxwkf7KCmByzBevrvGY634PhBFCXX6zVg at mail dot gmail dot com>
Manuel LÃpez-IbÃÃez <lopezibanez@gmail.com> writes:
> * Dodji: Do the common diagnostics part look reasonable?
Yes they do.
I just have one minor comment nit:
[...]
> Index: gcc/pretty-print.h
[...]
> +
> + /* Nonzero means that text should be flushed when
> + appropriate. Otherwise, text is buffered until either
> + pp_pp_really_flush or pp_clear_output_area are called. */
I think you wanted to say pp_really_flush, not pp_pp_realy_flush.
> + bool flush_p;
> };
[...]
Thanks!
--
Dodji