This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: Implementing OpenACC's Fortran module
- From: Tobias Burnus <burnus at net-b dot de>
- To: James Norris <jnorris at codesourcery dot com>
- Cc: Thomas Schwinge <thomas at codesourcery dot com>, fortran at gcc dot gnu dot org, jakub at redhat dot com
- Date: Wed, 20 Aug 2014 00:05:22 +0200
- Subject: Re: Implementing OpenACC's Fortran module
- Authentication-results: sourceware.org; auth=none
- References: <20140818093652 dot GA12023 at physik dot fu-berlin dot de> <53F1F025 dot 8080102 at codesourcery dot com> <20140818135104 dot GA8943 at physik dot fu-berlin dot de> <53F29628 dot 401 at codesourcery dot com> <53F3A8FC dot 9030105 at net-b dot de> <53F3B4DB dot 90506 at codesourcery dot com>
Hi James,
James Norris wrote:
I took care of the indenting.
Thanks!
I think the files are ready for upstream submitting unless you can
think of other things
that should done. Yes? No?
What do you mean by upstream? I assume gomp-4_0-branch and not yet GCC-5
trunk.
I think the patch is fine for the gomp-4_0-branch.
If you want to go beyond dumping the file there, you should also edit
the Makefile to install the .mod and .h file, and link the .o file. In
addition, you need to either cherry pick commit Rev. 213079 – or someone
has to merge the trunk into the branch. Given that the last merge was
more than a month ago, that's probably the better solution.
Tobias