This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch, libgfortran] [4.9/4.10 Regression] Internal read of negative integer broken
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Jerry DeLisle <jvdelisle at charter dot net>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 26 Jun 2014 13:29:48 +0200
- Subject: Re: [patch, libgfortran] [4.9/4.10 Regression] Internal read of negative integer broken
- Authentication-results: sourceware.org; auth=none
- References: <53AB7E5F dot 7010205 at charter dot net>
Hi Jerry,
The patch looks to be OK for trunk.
Did you check it with the NIST by any chance?
Thanks a lot
Paul
On 26 June 2014 03:58, Jerry DeLisle <jvdelisle@charter.net> wrote:
> Hi,
>
> This bug has nothing to do with negative numbers as in the description.
> However, the problem is due to seeking when there are no spaces to skip. I
> restructured the loop so that the skipping is not done if there are no spaces.
>
> Regression tested on x86-64. New test case from the PR.
>
> OK for trunk and 4.9?
>
> Regards,
>
> Jerry
>
> 2014-06-25 Jerry DeLisle <jvdelisle@gcc.gnu.org>
>
> PR libgfortran/61499
> * io/list_read.c (eat_spaces): Use a 'for' loop instead of
> 'while' loop to skip the loop if there are no bytes left in the
> string. Only seek if actual spaces can be skipped.
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy