This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, Fortran] PR57508 - Fix ICE/Reject-valid issue with get_temp_from_expr (intrinsic assignment with defined assignment)
- From: Mikael Morin <mikael dot morin at sfr dot fr>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: gcc patches <gcc-patches at gcc dot gnu dot org>, gfortran <fortran at gcc dot gnu dot org>
- Date: Fri, 14 Jun 2013 13:08:35 +0200
- Subject: Re: [Patch, Fortran] PR57508 - Fix ICE/Reject-valid issue with get_temp_from_expr (intrinsic assignment with defined assignment)
- References: <51ACA2CB dot 6010601 at net-b dot de> <51B441D6 dot 9030200 at sfr dot fr> <51BA07BE dot 4090205 at net-b dot de>
Le 13/06/2013 19:56, Tobias Burnus a écrit :
> Mikael Morin wrote:
>> This fixes the problem, but shouldn't the fix be in gfc_expr_attr
>> instead?
>
> I tried it - but it does not work: In many case, one actually needs a
> function, e.g. for procedure pointers or for C_FUNLOC. Thus, I had to
> add an additional flag to tell whether the function or the function
> result it needed. But instead of adding a Boolean flag to 55 calls,
> which can be false in 54 case and true in 1, I think that the original
> patch is better. It's the only case where not an attribute it checked -
> but where attributes are copied.
>
> Thus, is the original patch okay? Or do you have a better
> proposal?http://gcc.gnu.org/ml/fortran/2013-06/msg00027.html
>
Sorry, I didn't see what the problem really was.
Yes, the original patch is OK.
Mikael