This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, fortran] PR 39654 FTELL intrinsic

From: Tobias Burnus <burnus at net-b dot de>
To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
Cc: Fortran List <fortran at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 21 Jun 2012 14:34:38 +0200
Subject: Re: [Patch, fortran] PR 39654 FTELL intrinsic
References: <CAO9iq9FCJaOq83f4fV6Bw4knVe3+dOqxJokh6apKEHtq3Ze_6A@mail.gmail.com>

On 06/20/2012 11:28 PM, Janne Blomqvist wrote:

the attached patch makes the FTELL intrinsic function work on offsets
larger than 2 GB on 32-bit systems that support large files. As this
is an ABI change the old library function is left untouched, to be
removed when/if the library ABI is bumped.

Regtested on x86_64-unknown-linux-gnu, Ok for trunk?

The patch is okay; however, I wonder whether a name like "ftell64" or "ftell8" and a comment mentioning additionally the large-file support will help when reading the file.

Thanks for the patch.

Tobias

2012-06-21 Janne Blomqvist <jb@gcc.gnu.org>
	PR fortran/39654
	* iresolve.c (gfc_resolve_ftell): Fix result kind and use new
	library function.
library ChangeLog:

2012-06-21 Janne Blomqvist <jb@gcc.gnu.org>
	PR fortran/39654
	* io/intrinsics.c (ftell2): New function.
	* gfortran.map (_gfortran_ftell2): Export function.

Follow-Ups:
- Re: [Patch, fortran] PR 39654 FTELL intrinsic
  - From: Janne Blomqvist

References:
- [Patch, fortran] PR 39654 FTELL intrinsic
  - From: Janne Blomqvist

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]