This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: First Patch

Hello Daniel,

On 06/08/2011 07:16 PM, Tobias Burnus wrote:
I will later look at the patch itself.

Some comments - I have only glanced at the patch, but I think it otherwise looks okay.

- Don't forget to CC gcc-patches@ for the next (final?) version of the patch

- Spurious change? The spacing before looked OK:

-  if (!code->expr2&&  !(gfc_option.rtcheck&  GFC_RTCHECK_BOUNDS)
+   if (!code->expr2&&  !(gfc_option.rtcheck&  GFC_RTCHECK_BOUNDS)


- There should be no line break after "/*" in:

+      /*
+       SYNC ALL           =>    stat == null_pointer_node


- Spurious tab inserted (twice; third time with a space):

-
+


- if (stat) and "*stat =" missing for:

+++ libgfortran/caf/single.c	(working copy)
-  return 0;
+  status = 0;


Tobias

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]