This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, Fortran, OOP] PR 47240: segfault with procedure pointer component
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Janus Weil <janus at gcc dot gnu dot org>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 17 Jan 2011 06:30:58 +0100
- Subject: Re: [Patch, Fortran, OOP] PR 47240: segfault with procedure pointer component
- References: <AANLkTin_9Bz+YbN2=N3rYSiyGRRZbeAh51PZYzOpB+As@mail.gmail.com>
Dear Janus,
> 1) The hunk in trans-expr.c fixes the segfault in the original test
> case and is pretty much obvious.
Indeed, this is OK.
> 2) The hunk in resolve.c fixes the rejects-valid problem in comment
> #2. I think this should be ok, but I'm not 100% sure.
I wonder if you should not limit your condition to attr.proc_pointer
&& attr.function ?
> The patch was regtested on x86_64-unknown-linux-gnu. Ok for trunk?
>
Otherwise, it looks OK for trunk.
Thanks for the patch
Paul