This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, fortran] [0/11] Inline transpose part 1
- From: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: Mikael Morin <mikael dot morin at sfr dot fr>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 8 Sep 2010 22:40:02 +0300
- Subject: Re: [Patch, fortran] [0/11] Inline transpose part 1
- References: <4C8254A0.9020907@sfr.fr> <1283973787.8880.26.camel@linux-fd1f.site>
On Wed, Sep 8, 2010 at 22:23, Thomas Koenig <tkoenig@netcologne.de> wrote:
> Hello Mikael,
>
>> The good thing:
>> With the patches transpose(a+b) is handled without a temporary for (a + b).
>>
>> The bad thing:
>> With the patches function(transpose(a)) needs a temporary for
>> transpose(a) which was not needed before. This is due to the trans stage
>> trick which is gone, and will have to come back save us in
>> gfc_conv_expr_descriptor: this is the point of the inline transpose part
>> 2 patch serie (to come).
>
> The patchset is OK. ÂThanks a lot for the patches!
>
> Please do the second part before 4.6 comes out to avoid a regression.
>
> Also, I would recommend removing the transpose* functions from the
> fortran-dev branch once these patches have been committed there.
>
> Would it make sense to have a PR for both cases, to make sure they
> aren't forgotten?
>
> Best regards
>
> Â Â Â ÂThomas
>
>
If, as a result of these patches, the transpose implementation in
libgfortran is no longer needed, please add a note to
http://gcc.gnu.org/wiki/LibgfortranAbiCleanup
so that we remember to delete it once we bump the ABI.
--
Janne Blomqvist