Re: [PATCH, Fortran] Derived type finalization: Already somewhat useable...

[Daniel Kraft <d at domob dot eu>]

Tobias Burnus wrote:
> Daniel Kraft wrote:
> > > > [...]
> > > > General points I'm unsure about and would like to get extra-detailed 
> > > > review:
> > > >
> > > > * build_intrinsic_call is surely absolutelly ugly and wrong, I'd 
> > > > love to
> > > > get correction here as to how to do this the right way without this
> > > > symbol stuff, which seems to be causing some testsuite failures (for
> > > > instance, use_allocated_1.f90).  The current version just works for me
> > > > most of the time so I could use it for testing the other things 
> > > > based on it.

Hi Tobias,

because of my work on PR 33141 I just "managed" to create a test that 
tricks the current build_intrinsic_call: if, for instance, ALLOCATED is 
declared EXTERNAL and bound to a user-procedure, build_intrinsic_call 
will at the moment happily call this one and thus create possibly wrong 
finalization-code.

I'll work on this, it should probably be easy to fix; all that will be 
touched of the patch is build_intrinsic_call and possibly adapting the 
calls to this function.

Yours,
Daniel

PS: I tried to find the kind type parameters patch to give it a look but 
it seems it was not cycled to the list?  Can you forward it to me again, 
please?  Thanks!

--
Done:     Arc-Bar-Sam-Val-Wiz, Dwa-Elf-Gno-Hum-Orc, Law-Neu-Cha, Fem-Mal
Underway: Cav-Dwa-Law-Fem
To go:    Cav-Hea-Kni-Mon-Pri-Ran-Rog-Tou