This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: (new) Failure building GFortran (Cygwin)
- From: "Raksit Ashok" <raksit at google dot com>
- To: "Angelo Graziosi" <angelo dot graziosi at alice dot it>
- Cc: "Gabriel Dos Reis" <gdr at integrable-solutions dot net>, "Ian Lance Taylor" <iant at google dot com>, gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, gcc at gcc dot gnu dot org, "Dave Korn" <dave dot korn at artimi dot com>
- Date: Fri, 11 Jul 2008 11:10:13 -0700
- Subject: Re: (new) Failure building GFortran (Cygwin)
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1215799817; bh=ZjPFtfOa1EJVHmzvMCX+Gmp9ks0=; h=DomainKey-Signature:Message-ID:Date:From:To:Subject:Cc: In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-Disposition:References; b=CDrSI3tdKJ5zJy/cBmMPfSOY4w3k4LIj VHOdvigEfi6Coav1fAYBhNzTBxUNsmhpuQYuwTRKyhWeCkgocHHQTQ==
- Domainkey-signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=received:message-id:date:from:to:subject:cc:in-reply-to: mime-version:content-type:content-transfer-encoding: content-disposition:references; b=sWnZaILQyvo8Ua0qRJZLjMZGukMWPGBU9RcMrTE+RQIxXGBAlLtDhl98IX7RJ46R4 uORVbM3j276MgbVWOmvkg==
- References: <486629E7.7030003@alice.it> <4871D596.5000105@alice.it> <m3d4lp35ej.fsf@google.com> <487296E2.1090003@alice.it> <m37ibx1e3t.fsf@google.com> <4872ADD7.6060608@alice.it> <m3r6a5ypvl.fsf@google.com> <487329C5.4000101@alice.it> <206fcf960807081222i6b654f20na46f4c15f3ff8d76@mail.gmail.com> <4877151C.3000405@alice.it>
On Fri, Jul 11, 2008 at 1:09 AM, Angelo Graziosi
<angelo.graziosi@alice.it> wrote:
> Gabriel Dos Reis ha scritto:
>>
>> On Tue, Jul 8, 2008 at 3:48 AM, Angelo Graziosi
>> <> wrote:
>>>
>>> Ian Lance Taylor ha scritto:
>>>>
>>>> This is OK, with a ChangeLog entry, if it passes bootstrap with the
>>>> appropriate configure option.
>>>
>>> The following bootstraps rev. 137613, having configured as
>>>
>>> ${gcc_dir}/configure --prefix="${prefix_dir}" \
>>> --exec-prefix="${eprefix_dir}" \
>>> --sysconfdir="${sysconf_dir}" \
>>> --libdir="${lib_dir}" \
>>> --libexecdir="${libexec_dir}" \
>>> --mandir="${man_dir}" \
>>> --infodir="${info_dir}" \
>>> --enable-languages=c,fortran \
>>> --enable-bootstrap \
>>> --enable-decimal-float=bid \
>>> --enable-libgomp \
>>> --enable-threads \
>>> --enable-sjlj-exceptions \
>>> --enable-version-specific-runtime-libs \
>>> --enable-nls \
>>> --enable-checking=release \
>>> --disable-fixed-point \
>>> --disable-libmudflap \
>>> --disable-shared \
>>> --disable-win32-registry \
>>> --with-system-zlib \
>>> --without-included-gettext \
>>> --without-x
>>>
>>> ===========================================================
>>> gcc/ChangeLog:
>>> 2008-07-08 Angelo Graziosi <>
>>>
>>>
>>> * ggc-page.c (alloc_page):
>>> Substituting xmalloc, xcalloc with
>>> XNEWVEC and XCNEWVAR macros which add the
>>> needed casts.
>>>
>>>
>>>
>>> --- gcc.orig/gcc/ggc-page.c 2008-06-29 06:39:16.000000000 +0200
>>> +++ gcc/gcc/ggc-page.c 2008-07-08 09:00:20.906250000 +0200
>>> @@ -799,7 +799,7 @@
>>> alloc_size = GGC_QUIRE_SIZE * G.pagesize;
>>> else
>>> alloc_size = entry_size + G.pagesize - 1;
>>> - allocation = xmalloc (alloc_size);
>>> + allocation = XNEWVEC (char, alloc_size);
>>
>> OK.
>>
>>> page = (char *) (((size_t) allocation + G.pagesize - 1) &
>>> -G.pagesize);
>>> head_slop = page - allocation;
>>> @@ -842,7 +842,7 @@
>>> struct page_entry *e, *f = G.free_pages;
>>> for (a = enda - G.pagesize; a != page; a -= G.pagesize)
>>> {
>>> - e = xcalloc (1, page_entry_size);
>>> + e = XCNEWVAR (struct page_entry, page_entry_size);
>>
>> OK.
>>
>>
>>> e->order = order;
>>> e->bytes = G.pagesize;
>>> e->page = a;
>>> ===========================================================
>
> If the patch is OK, may someone apply/commit it so we can test it also with
> the next 4.4 snapshot?
Committed on Angelo's behalf as revision 137722. (I was running into
the same build failure on cygwin, and I validated that this patch
fixes the build failure and it bootstraps on i686-pc-cygwin and
i686-linux).
Thanks,
Raksit
>
>
> Thanks,
> Angelo.
>
> ---
> Pace è gioia!
>
>