This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: Is that OK to borrow code from coreutils?
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "Steve Kargl" <sgk at troutmask dot apl dot washington dot edu>
- Cc: "Joe Buck" <Joe dot Buck at synopsys dot com>, GCC <gcc at gcc dot gnu dot org>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, FX <fxcoudert at gmail dot com>
- Date: Wed, 9 Jul 2008 14:48:41 -0700
- Subject: Re: Is that OK to borrow code from coreutils?
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=wHIzFzNkQaFmzSLg+uWt9tROOB05qDZRatVNRG9lGYo=; b=IHC2oT0JLmEDRJWDWm7naoTCi18HZhMfKhHCvJ8OlLDUI6sHgH/7LuiWlv1F1cppVr jIraCpviLQikdwGRghUdVmiR2ewRTfG4+Ayx8uolkqIF12ODYIsHYkAajDbU+tASIz+t cF1hNHkgCYhx81KSUV/M485ggebh7bCLF1Y8k=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=xuJS5HGAmcQqnT/XP/mAgEaUGchfk52wQIFe7H6yil2zQRBcTwV2D5YktHMciZG1/n NEcNly0sTa1QxcGhNHFKjAiTfLGEw2ASA1LjmmbJqOUh0n/9e1TssEbqSRHUXBZhqISk G+rjhMlr+dKRGLg2VQW9qkP3s/fDwU4hs1Ur0=
- References: <6dc9ffc80807091307g40114fcfk55ae9b859bd7821b@mail.gmail.com> <20080709201743.GR12539@synopsys.com> <6dc9ffc80807091324u18a992f4p1fbb5ed2d95524e7@mail.gmail.com> <20080709205227.GA30739@troutmask.apl.washington.edu> <20080709205900.GU12539@synopsys.com> <6dc9ffc80807091420x64198255nf7742337042d85d4@mail.gmail.com> <20080709212957.GA41160@troutmask.apl.washington.edu>
On Wed, Jul 9, 2008 at 2:29 PM, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> On Wed, Jul 09, 2008 at 02:20:55PM -0700, H.J. Lu wrote:
>> On Wed, Jul 9, 2008 at 1:59 PM, Joe Buck <Joe.Buck@synopsys.com> wrote:
>> > On Wed, Jul 09, 2008 at 01:52:27PM -0700, Steve Kargl wrote:
>> >>
>> >> Do you have an application that shows that the current
>> >> implementation of chmod() is a bottleneck?
>> >
>> > Yes, this might be a case of "if it ain't broke, don't fix it".
>> >
>>
>> It is broken:
>
> Do you have an application that shows that it is broken?
>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36755
>
> I've read the PR.
>
>> The implementation in libgfortran is incorrect. It doesn't
>> handle signal nor check return from wait to match pid.
>
> In that chmod() is not defined by the Fortran Standard,
> how can you infer that libgfortran's implementation is
> incorrect?
>
Please read a decent UNIX system book or look how
system () is implemented in glibc.
--
H.J.