This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: Is that OK to borrow code from coreutils?
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "Joe Buck" <Joe dot Buck at synopsys dot com>
- Cc: "Steve Kargl" <sgk at troutmask dot apl dot washington dot edu>, GCC <gcc at gcc dot gnu dot org>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, FX <fxcoudert at gmail dot com>
- Date: Wed, 9 Jul 2008 14:20:55 -0700
- Subject: Re: Is that OK to borrow code from coreutils?
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=V7nF5iI22PWOH52s9mp3Y/afIRHhybtO0EZ2XGyiNs0=; b=L6b2kr9omfqrcvd10sCmYRga6tiatojczIUsfPZCjIY6bGzi/PMyI8t532/qiyO/hJ 5Bxa/RciTzh9GRrvlLd5X/5d8bxkW3AYcsUabpHcTFwAR1XAUaelDinabQiMQlYYOlLE EKdbsIOiXizPwBhEQE2t8IR0g6mwnmH6sWlf0=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=gjjBiS0lU8seruw1jxqJVW0xv0sU4E2k9IORVOKweqfSqjb2+1tlZ+E/DDhOtFUe8Q jfs4AtD99//NRTCjZ99YtocJV4crt8fiWDABhogiSGt7lEemVt3cg1THK1h/nSwSMbKU TrZgi0i8uQIlqyjRuQ3dmVpcFmrkm5xm6sXTQ=
- References: <6dc9ffc80807091307g40114fcfk55ae9b859bd7821b@mail.gmail.com> <20080709201743.GR12539@synopsys.com> <6dc9ffc80807091324u18a992f4p1fbb5ed2d95524e7@mail.gmail.com> <20080709205227.GA30739@troutmask.apl.washington.edu> <20080709205900.GU12539@synopsys.com>
On Wed, Jul 9, 2008 at 1:59 PM, Joe Buck <Joe.Buck@synopsys.com> wrote:
> On Wed, Jul 09, 2008 at 01:52:27PM -0700, Steve Kargl wrote:
>> On Wed, Jul 09, 2008 at 01:24:44PM -0700, H.J. Lu wrote:
>> > On Wed, Jul 9, 2008 at 1:17 PM, Joe Buck <Joe.Buck@synopsys.com> wrote:
>> > > On Wed, Jul 09, 2008 at 01:07:10PM -0700, H.J. Lu wrote:
>> > >> libgfortran calls fork/exec /bin/chmod to parse argument to chmod.
>> > >> Is that OK to borrow code from coreutils which implements /bin/chmod
>> > >> to properly implement chmod? coreutils is under GPLv3 while libgfortran
>> > >> is under GPLv2 + exception. Is that possible to get permission from
>> > >> the FSF to borrow code from coreutils?
>> > >
>> > > If the consensus of the Fortran maintainers is that this is the right
>> > > thing to do, the SC can ask the FSF for permission.
>> > >
>> >
>> > I don't know if this counts:
>> >
>> > http://gcc.gnu.org/ml/fortran/2008-07/msg00046.html
>> >
>>
>> Do you have an application that shows that the current
>> implementation of chmod() is a bottleneck?
>
> Yes, this might be a case of "if it ain't broke, don't fix it".
>
It is broken:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36755
The implementation in libgfortran is incorrect. It doesn't
handle signal nor check return from wait to match pid.
--
H.J.