This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)

From: FX Coudert <fxcoudert at gmail dot com>
To: Tobias Burnus <burnus at net-b dot de>
Cc: Andreas Schwab <schwab at suse dot de>, gcc-patches List <gcc-patches at gcc dot gnu dot org>, "fortran at gcc dot gnu dot org List" <fortran at gcc dot gnu dot org>
Date: Sat, 20 Jan 2007 17:50:06 +0100
Subject: Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer; b=RLr97stObeI9Sta16rDA+imOaa0PCwPl+aM3bo/nbBL8+iIh8R/j24+HfhjwP68uZyq5+TU24z6goSSMhGpI/zSxJKejYtb7XMSiW+Y4ZERTZqG8YryifUnoy3ycPuAhmJ8Lq6qxIOv4lTBPo1z5GwtpXS6XJagZRtvsPb2y8Ao=
References: <456DE55F.8000201@net-b.de> <45748891.2040300@net-b.de> <20061209213353.GA13405@meiner.onlinehome.de> <457BF272.20502@net-b.de> <je3b7nwxx6.fsf@sykes.suse.de> <457C542C.6050801@net-b.de> <jemz5vva21.fsf@sykes.suse.de> <45B0013C.4070604@net-b.de> <9058A00F-66CB-4D97-B3C7-DFAB8ECABE34@gmail.com> <45B23F27.4060800@net-b.de>

besides libgfortran, gettimeofday is currently used by
gcc/toplev.c, include/libiberty.h, libiberty/mkstemps.c,
libiberty/gettimeofday.c,
libjava/classpath/native/jni/java-lang/java_lang_VMSystem.c,
libmudflap/mf-runtime.c
and none of them uses a one-argument version of gettimeofday.

Now, that's a good argument!

2. As Andreas Schwab wrote, removing this configure test "would also make it possible to eliminate a runtime configure check." [...] "Runtime checks are bad for cross compiling."

But still better than not providing the functionality :)

Anyway, the first argument is very convincing. Your patch is thus OK to commit to mainline, and 4.2 after a one-week delay.

FX

References:
- Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)
  - From: Tobias Burnus
- Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)
  - From: FX Coudert
- Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)
  - From: Tobias Burnus

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]