This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch for fortran-experiments branch


On Thu, Jan 11, 2007 at 10:24:14AM -0700, Christopher D. Rickett wrote:
>i think i've fixed all of the coding style issues you pointed out.  here 
>are the updated diffs, with an entry in ChangeLog.isocbinding:

Brooks also said
you>+        }/* end if(c_ptr created) */
brooks>I think that end if comments like this are not the usual for GCC code.
(which i think too, fwiw)
brooks>Also, I find these more confusing than helpful, since they don't match
brooks>the opening "if" clause, and this one isn't the end of the if statement
brooks>because there's a following "else" clause.

but:
>
>Index: gcc/fortran/symbol.c
>===================================================================
>--- gcc/fortran/symbol.c        (revision 120681)
>+++ gcc/fortran/symbol.c        (working copy)
[]
>+         }/* end if(c_funptr created) */
>        break;
> 
>       case ISOCBINDING_F_POINTER:

cheers,
Bernhard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]