This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gfortran,patch] Handle "%3$d"-style format specifiers in error.c

From: FX Coudert <fxcoudert at gmail dot com>
To: Brooks Moses <brooks dot moses at codesourcery dot com>
Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Sat, 25 Nov 2006 20:32:08 +0100
Subject: Re: [gfortran,patch] Handle "%3$d"-style format specifiers in error.c
References: <AA28EA2F-10C1-47B6-837C-BBB948290C9E@gmail.com> <48C35A2B-091F-496D-BC19-5EE63C57B17A@gmail.com> <456890CE.3070208@codesourcery.com>

Hmm -- perhaps I should have been clearer that my "this otherwise looks ok to me" couldn't count as a formal review, because I'm not a maintainer? If so, my apologies.

Sorry for not being clearer myself. We (the listed gfortran maintainers) try to review patches, but we indeed have a right to check in our own patches. I felt that, with the detailed review you made, and the testing done, the patch was sufficiently safe to commit without requiring someone else to look at it.

Thanks again,
FX

References:
- [gfortran,patch] Handle "%3$d"-style format specifiers in error.c
  - From: FX Coudert
- Re: [gfortran,patch] Handle "%3$d"-style format specifiers in error.c
  - From: FX Coudert
- Re: [gfortran,patch] Handle "%3$d"-style format specifiers in error.c
  - From: Brooks Moses

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]