This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [PATCH] PR29759
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Daniel Franke <franke dot daniel at gmail dot com>
- Cc: fortran at gcc dot gnu dot org, jakub at redhat dot com
- Date: Thu, 9 Nov 2006 16:28:12 -0800
- Subject: Re: [PATCH] PR29759
- References: <200611100117.49366.franke.daniel@gmail.com>
On Fri, Nov 10, 2006 at 01:17:49AM +0100, Daniel Franke wrote:
>
>
> please find attached a proposed fix for PR29759 (ICE on OMP line
> continuation).
>
> The ICE occured because all lines starting with "!$" where checked
> against "!$OMP", even if they were known OMP conditional lines. The
> fix for this should qualify as obvious. Is a testcase needed?
>
> Regtested on i686-pc-linux-gnu.
>
> If it is acceptable, could someone commit it to trunk and 4.2?
>
> Thanks
Daniel,
You should CC your patch eamils to gcc-patches@gcc.gnu.org.
I've CC'd Jakub in that he has handled most Fortran OpenMP
stuff
Yes, a testcase should be created. Just add
! { dg-do compile }
to the top line of your small example. I'm not sure whether
this should go in gfortran.dg or one of the gomp testsuites?
Jakub?
--
Steve