This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] Add -fmax-errors option to limit the number of errors emitted.


Bernhard Fischer wrote:
On Wed, Nov 08, 2006 at 10:57:09PM -0800, Brooks Moses wrote:
+static void
+gfc_increment_error_count (void)
+{
+  errors++;
+  if ((gfc_option.max_errors != 0) && (errors >= gfc_option.max_errors))
+    gfc_fatal_error ("Error count reached limit of %d.", gfc_option.max_errors);

Quick question wrt the punctuation. It seems that the majority but not all of warning/error messages omit the trailing dot. Should this be made consistent, either to add or to omit the punctuation at the end of these messages?

I would think it should be consistent, one way or the other. My preference would be to include the punctuation (particularly in cases like this where the error message is essentially a complete sentence), but I think the GCC standard is probably to omit it.


(The GNU error-message standards [1] say to omit the period, but they also say not to use a capital letter at the beginning when the message follows a filename because the filename is the true start of the sentence. This, however, is not really standard English style -- when one has a partial sentence, a colon, and then a clause after it that is a full sentence, the clause normally starts with a capital letter despite being in the middle of the sentence. So I admit to harboring a bit of mistrust towards their suggestion to omit the period.)

Thanks for noticing that!
- Brooks


[1] http://www.gnu.org/prep/standards/html_node/Errors.html



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]