This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit


On Sun, Oct 22, 2006 at 09:08:02PM -0000, aldot at gcc dot gnu dot org wrote:
> 
> Created an attachment (id=12476)
>  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12476&action=view)
> untested proposed fix
> 
> I hope to test this patch soon.
> 
> Note that it adds a warning about blank common in block data but -- unlike the
> patch in the previous comment -- does accept the common instead of abandoning
> it via goto cleanup. Please advise if not cleaning this up is acceptable or if
> blank commons should be ignored there.
> 
> fortran/ChangeLog:
> 2006-10-22  Bernhard Fischer  <aldot@gcc.gnu.org>
> 
>         PR fortran/29537
>         * trans-common.c (gfc_trans_common): For unnamed block data the
>         proc_name is null, so use the locus of the common.
>         (gfc_sym_mangled_common_id): Fix whitespace.
>         * match.c (gfc_match_common): Emit warning about blank common in
>         block data.
> 
> testsuite/ChangeLog:
> 2006-10-22  Bernhard Fischer  <aldot@gcc.gnu.org>
> 
>         PR fortran/29537
>         * blockdata_1.f90: Add warning about blank common in block data.
>         * blockdata_2.f90: New testcase.
> 
> 

Bernhard, 

This is ok for trunk.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]