Re: revap types, step 1

[Steven Bosscher <stevenb at suse dot de>]

On Thursday 26 August 2004 08:14, Richard Henderson wrote:

> +   /* Choose the default integer kind.  We choose 4 unless the user
> +      directs us otherwise.  */
> +   if (gfc_option.i8)
> +     {
> +       if (saw_i8 < 0)
> + 	abort (); /* warning, error, fatal? */

Technically there is no requirement to support more than one kind
of integer, so it should be a fatal error.  Especially because a
user might like to know why the compiler dies on him if he specifies
a flag like -i8.


> +       gfc_default_integer_kind_1 = 8;
> +     }
> +   else if (saw_i4 >= 0)
> +     gfc_default_integer_kind_1 = 4;
> +   else
> +     abort (); /* choose?  */

Not sure.  How likely is it that there is a machine that does not have
a 32 bits integer (isn't S390 31 bits or something strange like that???).
I think a fatal error is good here, too.

Looks like a nice improvement to me.

I think some flag for the user to let the compiler print out the list
of supported types and the default precisions would be nice.  If others
think that's a good idea, I'll implement that.

Gr.
Steven