This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [PATCH] PR 16917: Add DFLOAT to gfortran
On Wednesday 11 August 2004 13:13, Paul Brook wrote:
> On Wednesday 11 August 2004 07:07, Steve Kargl wrote:
> > The attached patch adds support for DFLOAT to gfortran. This
> > is required for compatibility with g77 and several other vendor's
> > f77 implementations (e.g, f2c and HP-UX). This also fixes
> > PR 16917
>
> ChangeLog? Testcase?
A test case is (was?) in the g77 test suite.
The Changelog is indeed missing.
> Besides which patch looks wrong. You declare GFC_ISYM_DFLOAT, but don't use
> it. gfc_simplify_dfloat is never used.
That was a typo apparently. I overlooked it too.
+ add_sym_1 ("dfloat", 0, 1, BT_REAL, dd,
+ gfc_check_dfloat, gfc_simplify_dble, NULL,
+ x, BT_INTEGER, di, 0);
+
+ make_generic ("dfloat", GFC_ISYM_DBLE);
+
Sorry for the sloppy review.
Gr.
Steven