]> gcc.gnu.org Git - gcc.git/commit
libstdc++: Fix up lambda in join_view::_Iterator::operator++ [PR100290]
authorPatrick Palka <ppalka@redhat.com>
Tue, 27 Apr 2021 18:07:46 +0000 (14:07 -0400)
committerPatrick Palka <ppalka@redhat.com>
Tue, 27 Apr 2021 18:07:46 +0000 (14:07 -0400)
commit85ef4b8d4eb3313a48b79c7e752891f9646bb246
treedd8c1523f84bc420366f16f48c5d019c1ebb25fb
parentc605a8bf92708e81d771426a87b3baddc32082dd
libstdc++: Fix up lambda in join_view::_Iterator::operator++ [PR100290]

Currently, the return type of this lambda is decltype(auto), so the
lambda ends up returning a copy of _M_parent->_M_inner rather than a
reference to it when _S_ref_glvalue is false.  This means _M_inner and
ranges::end(__inner_range) are respectively an iterator and sentinel for
different ranges, so comparing them is undefined.

libstdc++-v3/ChangeLog:

PR libstdc++/100290
* include/std/ranges (join_view::_Iterator::operator++): Correct
the return type of the lambda to avoid returning a copy of
_M_parent->_M_inner.
* testsuite/std/ranges/adaptors/join.cc (test10): New test.
libstdc++-v3/include/std/ranges
libstdc++-v3/testsuite/std/ranges/adaptors/join.cc
This page took 0.060326 seconds and 5 git commands to generate.