]> gcc.gnu.org Git - gcc.git/commit
ragen-op-float: Fix up float_binary_op_range_finish [PR107668]
authorJakub Jelinek <jakub@redhat.com>
Wed, 16 Nov 2022 06:30:07 +0000 (07:30 +0100)
committerJakub Jelinek <jakub@redhat.com>
Wed, 16 Nov 2022 06:30:07 +0000 (07:30 +0100)
commit7c6cd9c05efca29a1a9635b81c86cbad25bbdbbe
tree241f98b0b5db21c5780b4e35952506f52dab6186
parent2b7f0378b915a6a294b330bea00e50069f181bd7
ragen-op-float: Fix up float_binary_op_range_finish [PR107668]

The following testcase ICEs, because when !HONOR_NANS but
HONOR_SIGNED_ZEROS, if we see
lhs = op1 * op2;
and know that lhs is [-0.0, 0.0] and op2 is [0.0, 0.0], the
division of these two yields UNDEFINED and clear_nan () on it
fails an assert.  With HONOR_NANS it would actually result in
a known NAN, but when NANs aren't honored, we clear the NAN bits.
Now, for the above case we actually don't know anything about
the op1 range (except that it isn't a NAN/INF because of
!HONOR_NANS !HONOR_INFINITIES), so I think the best is just
to return VARYING for the case we get UNDEFINED as well.

If we want, the op[12]_range methods perhaps can handle the
corner cases earlier separately, say for
lhs [0.0, 0.0] and op2 [0.0, 0.0] when HONOR_SIGNED_ZEROS this
would be just [0.0, MAX].

2022-11-16  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/107668
* range-op-float.cc (float_binary_op_range_finish): Set VARYING
also when r is UNDEFINED.

* gcc.dg/ubsan/pr107668.c: New test.
gcc/range-op-float.cc
gcc/testsuite/gcc.dg/ubsan/pr107668.c [new file with mode: 0644]
This page took 0.061542 seconds and 5 git commands to generate.