From 75d850f3681a4f907b43983936db7f28a2ec230d Mon Sep 17 00:00:00 2001 From: Patrick Palka Date: Mon, 31 Mar 2014 20:48:33 -0400 Subject: [PATCH] re PR c++/44859 (missed warning: returning reference to temporary) PR c++/44859 * typeck.c (maybe_warn_about_returning_address_of_local): Unwrap COMPONENT_REFs and ARRAY_REFs sooner. From-SVN: r208970 --- gcc/cp/ChangeLog | 6 ++++++ gcc/cp/typeck.c | 8 ++++---- gcc/testsuite/g++.dg/warn/Wreturn-local-addr-2.C | 11 +++++++++++ 3 files changed, 21 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/g++.dg/warn/Wreturn-local-addr-2.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index aca5f44c4313..553a05976cf1 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2014-03-31 Patrick Palka patrick@parcs.ath.cx + + PR c++/44859 + * typeck.c (maybe_warn_about_returning_address_of_local): Unwrap + COMPONENT_REFs and ARRAY_REFs sooner. + 2014-03-29 Adam Butcher PR c++/60626 diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c index 559f19b55df3..9a80727dd8e4 100644 --- a/gcc/cp/typeck.c +++ b/gcc/cp/typeck.c @@ -8283,6 +8283,10 @@ maybe_warn_about_returning_address_of_local (tree retval) return; whats_returned = TREE_OPERAND (whats_returned, 0); + while (TREE_CODE (whats_returned) == COMPONENT_REF + || TREE_CODE (whats_returned) == ARRAY_REF) + whats_returned = TREE_OPERAND (whats_returned, 0); + if (TREE_CODE (valtype) == REFERENCE_TYPE) { if (TREE_CODE (whats_returned) == AGGR_INIT_EXPR @@ -8300,10 +8304,6 @@ maybe_warn_about_returning_address_of_local (tree retval) } } - while (TREE_CODE (whats_returned) == COMPONENT_REF - || TREE_CODE (whats_returned) == ARRAY_REF) - whats_returned = TREE_OPERAND (whats_returned, 0); - if (DECL_P (whats_returned) && DECL_NAME (whats_returned) && DECL_FUNCTION_SCOPE_P (whats_returned) diff --git a/gcc/testsuite/g++.dg/warn/Wreturn-local-addr-2.C b/gcc/testsuite/g++.dg/warn/Wreturn-local-addr-2.C new file mode 100644 index 000000000000..c483601e6b23 --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wreturn-local-addr-2.C @@ -0,0 +1,11 @@ +// PR c++/44859 + +struct Base2 { int m_foo; }; +struct Derived2 : public Base2 {}; + +const Base2& f8() { return Derived2(); } // { dg-warning "reference to temporary" } + +struct foo { }; +struct bar { foo base; }; + +const foo& f9() { return bar().base; } // { dg-warning "reference to temporary" } -- 2.43.5