]> gcc.gnu.org Git - gcc.git/commit
c++: Fix bogus warning in deprecated namespace [PR99318]
authorMarek Polacek <polacek@redhat.com>
Wed, 10 Mar 2021 00:23:48 +0000 (19:23 -0500)
committerMarek Polacek <polacek@redhat.com>
Tue, 23 Mar 2021 14:54:27 +0000 (10:54 -0400)
commit831f9f768eb1fbf9a31d9a89591188b1487b6376
treef669472b52c00bfee13bbfde872162e30f0a9e94
parent212f4988f37ccf788c8c72b1dc952980bc9be3b7
c++: Fix bogus warning in deprecated namespace [PR99318]

In GCC 10, I introduced cp_warn_deprecated_use_scopes so that we can
handle attribute deprecated on a namespace declaration.  This
function walks the decl's contexts so that we warn for code like

  namespace [[deprecated]] N { struct S { }; }
  N::S s;

We call cp_warn_deprecated_use_scopes when we encounter a TYPE_DECL.
But in the following testcase we have a TYPE_DECL whose context is
a deprecated function; that itself is not a reason to warn.  This
patch limits for which entities we call cp_warn_deprecated_use;
essentially it's what can follow ::.

I noticed that we didn't test that

  struct [[deprecated]] S { static void fn(); };
  S::fn();

produces the expected warning, so I've added gen-attrs-73.C.

gcc/cp/ChangeLog:

PR c++/99318
* decl2.c (cp_warn_deprecated_use_scopes): Only call
cp_warn_deprecated_use when decl is a namespace, class, or enum.

gcc/testsuite/ChangeLog:

PR c++/99318
* g++.dg/cpp0x/attributes-namespace6.C: New test.
* g++.dg/cpp0x/gen-attrs-73.C: New test.
gcc/cp/decl2.c
gcc/testsuite/g++.dg/cpp0x/attributes-namespace6.C [new file with mode: 0644]
gcc/testsuite/g++.dg/cpp0x/gen-attrs-73.C [new file with mode: 0644]
This page took 0.060273 seconds and 5 git commands to generate.