]> gcc.gnu.org Git - gcc.git/commit
tree-optimization: [PR108684] ICE in verify_ssa due to simple_dce_from_worklist
authorAndrew Pinski <apinski@marvell.com>
Tue, 7 Feb 2023 23:09:40 +0000 (23:09 +0000)
committerAndrew Pinski <apinski@marvell.com>
Fri, 10 Feb 2023 01:47:05 +0000 (17:47 -0800)
commit6a5cb782d1486b378d70857c8efae558da0eb2cc
tree933272dcb4a22f6fa1e468d4a93171c3d860bc61
parentb9f8935e110c392c21460db838b4209c32f070c2
tree-optimization: [PR108684] ICE in verify_ssa due to simple_dce_from_worklist

In simple_dce_from_worklist, we were removing an inline-asm which had a vdef.
We should not be removing inline-asm which have a vdef as this code
does not check to the store.
This fixes that oversight. This was a latent bug exposed recently
by both VRP and removal of stores to static starting to use
simple_dce_from_worklist.

Committed as approved.
Bootstrapped and tested on x86_64-linux-gnu with no regressions.

PR tree-optimization/108684

gcc/ChangeLog:

* tree-ssa-dce.cc (simple_dce_from_worklist):
Check all ssa names and not just non-vdef ones
before accepting the inline-asm.
Call unlink_stmt_vdef on the statement before
removing it.

gcc/testsuite/ChangeLog:

* gcc.c-torture/compile/dce-inline-asm-1.c: New test.
* gcc.c-torture/compile/dce-inline-asm-2.c: New test.
* gcc.dg/tree-ssa/pr108684-1.c: New test.

co-authored-by: Andrew Macleod  <amacleod@redhat.com>
gcc/testsuite/gcc.c-torture/compile/dce-inline-asm-1.c [new file with mode: 0644]
gcc/testsuite/gcc.c-torture/compile/dce-inline-asm-2.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/tree-ssa/pr108684-1.c [new file with mode: 0644]
gcc/tree-ssa-dce.cc
This page took 0.068298 seconds and 5 git commands to generate.