From: Jason Merrill Date: Thu, 21 Jul 2022 00:00:58 +0000 (-0400) Subject: c++: defaulted friend op== [PR106361] X-Git-Tag: Thesis~4607 X-Git-Url: https://gcc.gnu.org/git/?a=commitdiff_plain;h=28be481cf47d52af8b11972d2394226bbaf87867;p=gcc.git c++: defaulted friend op== [PR106361] Now non-member functions can be defaulted, so this assert is wrong. move_signature_fn_p already checks for ctor or op=. PR c++/106361 gcc/cp/ChangeLog: * decl.cc (move_fn_p): Remove assert. gcc/testsuite/ChangeLog: * g++.dg/cpp2a/spaceship-eq14.C: New test. --- diff --git a/gcc/cp/decl.cc b/gcc/cp/decl.cc index aa6cf3c6c2eb..70ad681467ee 100644 --- a/gcc/cp/decl.cc +++ b/gcc/cp/decl.cc @@ -15022,8 +15022,6 @@ copy_fn_p (const_tree d) bool move_fn_p (const_tree d) { - gcc_assert (DECL_FUNCTION_MEMBER_P (d)); - if (cxx_dialect == cxx98) /* There are no move constructors if we are in C++98 mode. */ return false; diff --git a/gcc/testsuite/g++.dg/cpp2a/spaceship-eq14.C b/gcc/testsuite/g++.dg/cpp2a/spaceship-eq14.C new file mode 100644 index 000000000000..896e5232bf69 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp2a/spaceship-eq14.C @@ -0,0 +1,17 @@ +// PR c++/106361 +// { dg-do compile { target c++20 } } + +struct foo { + int x; +}; + +struct bar { + foo f; // { dg-error "operator==" } + friend bool operator==(const bar& a, const bar& b); +}; + +bool operator==(const bar& a, const bar& b) = default; + +int main() { + return bar{} == bar{}; // { dg-error "deleted" } +}