Fix ICE with cast of division by zero (PR c/93348).

Bug 93348 reports an ICE on certain cases of casts of expressions that
may appear only in unevaluated parts of integer constant expressions,
arising from the generation of nested C_MAYBE_CONST_EXPRs.  This patch
fixes it by adding a call to remove_c_maybe_const_expr in the
integer-operands case, as is done in other similar cases.

Bootstrapped with no regressions for x86_64-pc-linux-gnu.

	PR c/93348
gcc/c:
	* c-typeck.c (build_c_cast): Call remove_c_maybe_const_expr on
	argument with integer operands.

gcc/testsuite:
	* gcc.c-torture/compile/pr93348-1.c: New test.

(cherry picked from commit ac68e287fc2e939ae6b45ba7ff04e493982b7f62)

diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog
index d07af203e1a648160ba5feb03d30a4799d0f034b..50fb412634d6abc18385fc9f026428059abdc938 100644 (file)
--- a/gcc/c/ChangeLog
+++ b/gcc/c/ChangeLog
@@ -1,3 +1,12 @@
+2020-01-22  Joseph Myers  <joseph@codesourcery.com>
+
+       Backport from mainline:
+       2020-01-22  Joseph Myers  <joseph@codesourcery.com>
+
+       PR c/93348
+       * c-typeck.c (build_c_cast): Call remove_c_maybe_const_expr on
+       argument with integer operands.
+
 2020-01-15  Joseph Myers  <joseph@codesourcery.com>
 
        Backport from mainline:

diff --git a/gcc/c/c-typeck.c b/gcc/c/c-typeck.c
index 00536d2a00b0ad31db2584c0e42e25f1a97187c2..8c4a1939f3db5839cbee9a33a8faf41d337a7fc8 100644 (file)
--- a/gcc/c/c-typeck.c
+++ b/gcc/c/c-typeck.c
@@ -5544,6 +5544,8 @@ build_c_cast (location_t loc, tree type, tree expr)
     expr = TREE_OPERAND (expr, 0);
 
   value = expr;
+  if (int_operands)
+    value = remove_c_maybe_const_expr (value);
 
   if (type == error_mark_node || expr == error_mark_node)
     return error_mark_node;

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 5e769101ff35807ddbdb26426a66d7c5b7465b53..b943d22bf6f40f1cb458d136b1043af3abbd7f1c 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,11 @@
+2020-01-22  Joseph Myers  <joseph@codesourcery.com>
+
+       Backport from mainline:
+       2020-01-22  Joseph Myers  <joseph@codesourcery.com>
+
+       PR c/93348
+       * gcc.c-torture/compile/pr93348-1.c: New test.
+
 2020-01-15  Joseph Myers  <joseph@codesourcery.com>
 
        Backport from mainline:

diff --git a/gcc/testsuite/gcc.c-torture/compile/pr93348-1.c b/gcc/testsuite/gcc.c-torture/compile/pr93348-1.c
new file mode 100644 (file)
index 0000000..d2edec5
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/compile/pr93348-1.c
@@ -0,0 +1,5 @@
+int
+ya (void)
+{
+  return (long int) (1 / 0);
+}