]> gcc.gnu.org Git - gcc.git/commitdiff
ServerSocket.java (accept): Remove bogus security check.
authorAnthony Green <green@redhat.com>
Sun, 15 Jan 2006 03:00:21 +0000 (03:00 +0000)
committerAnthony Green <green@gcc.gnu.org>
Sun, 15 Jan 2006 03:00:21 +0000 (03:00 +0000)
2006-01-14  Anthony Green  <green@redhat.com>

        * java/net/ServerSocket.java (accept): Remove bogus
        security check.
(implAccept): Add FIXME comment.

From-SVN: r109719

libjava/classpath/ChangeLog
libjava/classpath/java/net/ServerSocket.java

index 85df787cc4d6a265db7bef4c2c0f4d14988b0cd7..75e139eec7fc4a8606baf03f7c6a85e1df1d69f1 100644 (file)
@@ -1,3 +1,9 @@
+2006-01-14  Anthony Green  <green@redhat.com>
+
+        * java/net/ServerSocket.java (accept): Remove bogus
+        security check.
+       (implAccept): Add FIXME comment.
+
 2005-12-27  Tom Tromey  <tromey@redhat.com>
 
        * gnu/java/nio/SelectorImpl.java: Added import.
index afc861403a12df3e994f13a0a35d6a4054c5dbef..aa2fc0fb7b6930c5ff6f217e2c1c5a950bcd9592 100644 (file)
@@ -314,11 +314,6 @@ public class ServerSocket
    */
   public Socket accept() throws IOException
   {
-    SecurityManager sm = System.getSecurityManager();
-    if (sm != null)
-      sm.checkAccept(impl.getInetAddress().getHostAddress(),
-                     impl.getLocalPort());
-
     Socket socket = new Socket();
 
     try
@@ -360,6 +355,9 @@ public class ServerSocket
     if (isClosed())
       throw new SocketException("ServerSocket is closed");
 
+    // FIXME: Add a security check to make sure we're allowed to 
+    // connect to the remote host.
+
     // The Sun spec says that if we have an associated channel and
     // it is in non-blocking mode, we throw an IllegalBlockingModeException.
     // However, in our implementation if the channel itself initiated this
This page took 0.077134 seconds and 5 git commands to generate.