Fix all known bugs remaining in sparc64 constant formation.

	* config/sparc/sparc.c (sparc_emit_set_const64_quick1): If
	emitting a XOR of -1 at the end, emit a NOT instead for combine's
	sake.
	(sparc_emit_set_const64): Likewise, also when computing trailing
	bits do not negate low_bits and make fast_int an int.

From-SVN: r21748

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index d323f6f93166bd0bf33586ebea501d83eb0bbc86..39be7a8d9fe4c65ac8687f7780dec43948bb695d 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,11 @@
+Sat Aug 15 06:28:19 1998  David S. Miller  <davem@pierdol.cobaltmicro.com>
+
+       * config/sparc/sparc.c (sparc_emit_set_const64_quick1): If
+       emitting a XOR of -1 at the end, emit a NOT instead for combine's
+       sake.
+       (sparc_emit_set_const64): Likewise, also when computing trailing
+       bits do not negate low_bits and make fast_int an int.
+
 Fri Aug 14 21:07:03 1998  Jeffrey A Law  (law@cygnus.com)
 
        * loop.c (add_label_notes): Do not ignore references to labels

diff --git a/gcc/config/sparc/sparc.c b/gcc/config/sparc/sparc.c
index 6651ee3a75e0871b4393d8a20de8cfa0547c9af6..56cc02a7f765832c12f632253476c0ade8d1b58a 100644 (file)
--- a/gcc/config/sparc/sparc.c
+++ b/gcc/config/sparc/sparc.c
@@ -1336,12 +1336,27 @@ sparc_emit_set_const64_quick1 (op0, temp, low_bits, is_neg)
 
   sparc_emit_set_safe_HIGH64 (temp, high_bits);
   if (!is_neg)
-    emit_insn (gen_rtx_SET (VOIDmode, op0,
-                           gen_safe_OR64 (temp, (high_bits & 0x3ff))));
+    {
+      emit_insn (gen_rtx_SET (VOIDmode, op0,
+                             gen_safe_OR64 (temp, (high_bits & 0x3ff))));
+    }
   else
-    emit_insn (gen_rtx_SET (VOIDmode, op0,
-                           gen_safe_XOR64 (temp,
-                                           (-0x400 | (low_bits & 0x3ff)))));
+    {
+      /* If we are XOR'ing with -1, then we should emit a one's complement
+        instead.  This way the combiner will notice logical operations
+        such as ANDN later on and substitute.  */
+      if ((low_bits & 0x3ff) == 0x3ff)
+       {
+         emit_insn (gen_rtx_SET (VOIDmode, op0,
+                                 gen_rtx_NOT (DImode, temp)));
+       }
+      else
+       {
+         emit_insn (gen_rtx_SET (VOIDmode, op0,
+                                 gen_safe_XOR64 (temp,
+                                                 (-0x400 | (low_bits & 0x3ff)))));
+       }
+    }
 }
 
 static void sparc_emit_set_const64_quick2
@@ -1453,7 +1468,7 @@ sparc_emit_set_const64_longway (op0, temp, high_bits, low_bits)
 
       /* We are in the middle of reload, so this is really
         painful.  However we do still make an attempt to
-        avoid emmitting truly stupid code.  */
+        avoid emitting truly stupid code.  */
       if (low1 != const0_rtx)
        {
          emit_insn (gen_rtx_SET (VOIDmode, op0,
@@ -1795,17 +1810,20 @@ sparc_emit_set_const64 (op0, op1)
   if (const64_is_2insns ((~high_bits) & 0xffffffff,
                         (~low_bits) & 0xfffffc00))
     {
-      unsigned HOST_WIDE_INT trailing_bits = (~low_bits) & 0x3ff;
+      /* NOTE: The trailing bits get XOR'd so we need the
+        non-negated bits, not the negated ones.  */
+      unsigned HOST_WIDE_INT trailing_bits = low_bits & 0x3ff;
 
       if ((((~high_bits) & 0xffffffff) == 0
           && ((~low_bits) & 0x80000000) == 0)
          || (((~high_bits) & 0xffffffff) == 0xffffffff
              && ((~low_bits) & 0x80000000) != 0))
        {
-         HOST_WIDE_INT fast_int = (~low_bits & 0xffffffff);
+         int fast_int = (~low_bits & 0xffffffff);
 
-         if (SPARC_SETHI_P (fast_int)
-             || SPARC_SIMM13_P (((int)fast_int)))
+         if ((SPARC_SETHI_P (fast_int)
+              && (~high_bits & 0xffffffff) == 0)
+             || SPARC_SIMM13_P (fast_int))
            emit_insn (gen_safe_SET64 (temp, fast_int));
          else
            sparc_emit_set_const64 (temp, GEN_INT64 (fast_int));
@@ -1823,10 +1841,22 @@ sparc_emit_set_const64 (op0, op1)
 #endif
          sparc_emit_set_const64 (temp, negated_const);
        }
-      emit_insn (gen_rtx_SET (VOIDmode,
-                             op0,
-                             gen_safe_XOR64 (temp,
-                                             (-0x400 | trailing_bits))));
+
+      /* If we are XOR'ing with -1, then we should emit a one's complement
+        instead.  This way the combiner will notice logical operations
+        such as ANDN later on and substitute.  */
+      if (trailing_bits == 0x3ff)
+       {
+         emit_insn (gen_rtx_SET (VOIDmode, op0,
+                                 gen_rtx_NOT (DImode, temp)));
+       }
+      else
+       {
+         emit_insn (gen_rtx_SET (VOIDmode,
+                                 op0,
+                                 gen_safe_XOR64 (temp,
+                                                 (-0x400 | trailing_bits))));
+       }
       return;
     }