]> gcc.gnu.org Git - gcc.git/commitdiff
libstdc++: Add missing move in ranges::copy
authorJonathan Wakely <jwakely@redhat.com>
Thu, 3 Nov 2022 09:17:57 +0000 (09:17 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Thu, 3 Nov 2022 11:32:43 +0000 (11:32 +0000)
This is needed to support a move-only output iterator when the input
iterators are specializations of __normal_iterator.

libstdc++-v3/ChangeLog:

* include/bits/ranges_algobase.h (__detail::__copy_or_move):
Move output iterator.
* testsuite/25_algorithms/copy/constrained.cc: Check copying to
move-only output iterator.

libstdc++-v3/include/bits/ranges_algobase.h
libstdc++-v3/testsuite/25_algorithms/copy/constrained.cc

index f6f0b9c83b06a3a7e28c683e684ce182a1ce83b6..443ad52ecc62daaad82833e5fe37d4c96316e0ab 100644 (file)
@@ -239,7 +239,7 @@ namespace ranges
        {
          auto [__in,__out]
            = ranges::__copy_or_move<_IsMove>(__first.base(), __last.base(),
-                                             __result);
+                                             std::move(__result));
          return {decltype(__first){__in}, std::move(__out)};
        }
       else if constexpr (__is_normal_iterator<_Out>)
index 98f038a6c5fd25729c7e0fbeef7494aa26ca1207..444dfa78894095d4cfcc16f93b27cbe1e07e006c 100644 (file)
@@ -226,6 +226,29 @@ test06()
   VERIFY( ranges::equal(v, (int[]){1,2,3,0}) );
 }
 
+void
+test07()
+{
+  struct move_only_output_iterator
+  {
+    using value_type = int;
+    using difference_type = short;
+    using iterator_category = std::output_iterator_tag;
+
+    move_only_output_iterator() = default;
+    move_only_output_iterator(move_only_output_iterator&&) = default;
+    move_only_output_iterator& operator=(move_only_output_iterator&&) = default;
+
+    move_only_output_iterator& operator*() { return *this; }
+    move_only_output_iterator& operator++() { return *this; }
+    move_only_output_iterator operator++(int) { return std::move(*this); }
+
+    void operator=(int) { }
+  };
+
+  ranges::copy(std::vector<int>{1,2,3}, move_only_output_iterator{});
+}
+
 int
 main()
 {
@@ -235,4 +258,5 @@ main()
   test04();
   static_assert(test05());
   test06();
+  test07();
 }
This page took 0.057285 seconds and 5 git commands to generate.