re PR c++/4574 (Internal compiler error in `expand_and', at expmed.c:4055)

	PR c++/4574
	* expr.h (expand_and): Add mode argument.
	* expmed.c (expand_and): Add mode argument.
	(expand_mult_highpart_adjust, emit_store_flag): Adjust callers.
	* expr.c (store_field, expand_expr, do_store_flag): Likewise.
	* except.c (expand_builtin_extract_return_addr): Likewise.
	* config/alpha/alpha.c (alpha_initialize_trampoline): Likewise.
	* config/sparc/sparc.c (sparc_initialize_trampoline): Likewise.
	* config/c4x/c4x.h (INITIALIZE_TRAMPOLINE): Likewise.
	Use GEN_INT (x) instead of gen_rtx (CONST_INT, VOIDmode, x).
	* config/c4x/c4x.md: Use GEN_INT (x) instead of
	gen_rtx (CONST_INT, VOIDmode, x).

	* gcc.dg/20020220-1.c: New test.

From-SVN: r49938

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 7570480e189d846c1916fc20046e8f6ced088b9b..2805d63dfc4afec01988dc3f7605a5aa6d74312d 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,18 @@
+2002-02-20  Jakub Jelinek  <jakub@redhat.com>
+
+       PR c++/4574
+       * expr.h (expand_and): Add mode argument.
+       * expmed.c (expand_and): Add mode argument.
+       (expand_mult_highpart_adjust, emit_store_flag): Adjust callers.
+       * expr.c (store_field, expand_expr, do_store_flag): Likewise.
+       * except.c (expand_builtin_extract_return_addr): Likewise.
+       * config/alpha/alpha.c (alpha_initialize_trampoline): Likewise.
+       * config/sparc/sparc.c (sparc_initialize_trampoline): Likewise.
+       * config/c4x/c4x.h (INITIALIZE_TRAMPOLINE): Likewise.
+       Use GEN_INT (x) instead of gen_rtx (CONST_INT, VOIDmode, x).
+       * config/c4x/c4x.md: Use GEN_INT (x) instead of
+       gen_rtx (CONST_INT, VOIDmode, x).
+
 2002-02-21  Jakub Jelinek  <jakub@redhat.com>
 
        PR c/4697:

diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c
index 0f4bd14eca3c80feec62fddd867e1d38387425fa..69f7870eeb17f5577a740d849b09e27c58578300 100644 (file)
--- a/gcc/config/alpha/alpha.c
+++ b/gcc/config/alpha/alpha.c
@@ -5503,12 +5503,13 @@ alpha_initialize_trampoline (tramp, fnaddr, cxt, fnofs, cxtofs, jmpofs)
                           OPTAB_WIDEN);
       temp = expand_shift (RSHIFT_EXPR, Pmode, temp,
                           build_int_2 (2, 0), NULL_RTX, 1);
-      temp = expand_and (gen_lowpart (SImode, temp), GEN_INT (0x3fff), 0);
+      temp = expand_and (SImode, gen_lowpart (SImode, temp),
+                        GEN_INT (0x3fff), 0);
 
       /* Merge in the hint.  */
       addr = memory_address (SImode, plus_constant (tramp, jmpofs));
       temp1 = force_reg (SImode, gen_rtx_MEM (SImode, addr));
-      temp1 = expand_and (temp1, GEN_INT (0xffffc000), NULL_RTX);
+      temp1 = expand_and (SImode, temp1, GEN_INT (0xffffc000), NULL_RTX);
       temp1 = expand_binop (SImode, ior_optab, temp1, temp, temp1, 1,
                            OPTAB_WIDEN);
       emit_move_insn (gen_rtx_MEM (SImode, addr), temp1);

diff --git a/gcc/config/c4x/c4x.h b/gcc/config/c4x/c4x.h
index 15c0a2b405dc9bd026d93c5ca2475604068a28cf..5ae16ab3306490d234ad22e236058373148670d0 100644 (file)
--- a/gcc/config/c4x/c4x.h
+++ b/gcc/config/c4x/c4x.h
@@ -2169,32 +2169,26 @@ do { fprintf (asm_out_file, "\t.sdef\t");               \
       tmp1 = expand_shift (RSHIFT_EXPR, QImode, FNADDR,                        \
                           size_int (16), 0, 1);                        \
       tmp2 = expand_shift (LSHIFT_EXPR, QImode,                                \
-                          gen_rtx (CONST_INT, VOIDmode, 0x5069),       \
-                          size_int (16), 0, 1);                        \
+                          GEN_INT (0x5069), size_int (16), 0, 1);      \
       emit_insn (gen_iorqi3 (tmp1, tmp1, tmp2));                       \
       emit_move_insn (gen_rtx (MEM, QImode,                            \
                               plus_constant (tramp, 0)), tmp1);        \
-      tmp1 = expand_and (FNADDR, gen_rtx (CONST_INT, VOIDmode,         \
-                                         0xffff), 0);                  \
+      tmp1 = expand_and (QImode, FNADDR, GEN_INT (0xffff), 0);         \
       tmp2 = expand_shift (LSHIFT_EXPR, QImode,                                \
-                          gen_rtx (CONST_INT, VOIDmode, 0x1069),       \
-                          size_int (16), 0, 1);                        \
+                          GEN_INT (0x1069), size_int (16), 0, 1);      \
       emit_insn (gen_iorqi3 (tmp1, tmp1, tmp2));                       \
       emit_move_insn (gen_rtx (MEM, QImode,                            \
                               plus_constant (tramp, 2)), tmp1);        \
       tmp1 = expand_shift (RSHIFT_EXPR, QImode, CXT,                   \
                           size_int (16), 0, 1);                        \
       tmp2 = expand_shift (LSHIFT_EXPR, QImode,                                \
-                          gen_rtx (CONST_INT, VOIDmode, 0x5068),       \
-                          size_int (16), 0, 1);                        \
+                          GEN_INT (0x5068), size_int (16), 0, 1);      \
       emit_insn (gen_iorqi3 (tmp1, tmp1, tmp2));                       \
       emit_move_insn (gen_rtx (MEM, QImode,                            \
                               plus_constant (tramp, 3)), tmp1);        \
-      tmp1 = expand_and (CXT, gen_rtx (CONST_INT, VOIDmode,            \
-                                      0xffff), 0);                     \
+      tmp1 = expand_and (QImode, CXT, GEN_INT (0xffff), 0);            \
       tmp2 = expand_shift (LSHIFT_EXPR, QImode,                                \
-                          gen_rtx (CONST_INT, VOIDmode, 0x1068),       \
-                          size_int (16), 0, 1);                        \
+                          GEN_INT (0x1068), size_int (16), 0, 1);      \
       emit_insn (gen_iorqi3 (tmp1, tmp1, tmp2));                       \
       emit_move_insn (gen_rtx (MEM, QImode,                            \
                               plus_constant (tramp, 6)), tmp1);        \

diff --git a/gcc/config/c4x/c4x.md b/gcc/config/c4x/c4x.md
index c365489aa9dcb6adfceeeaabbcdb4067c0bd986b..242ed154cfe8309322af82b4e65da45bad97e9ce 100644 (file)
--- a/gcc/config/c4x/c4x.md
+++ b/gcc/config/c4x/c4x.md
@@ -984,8 +984,8 @@
    (set (match_dup 0) (ior:QI (match_dup 0) (match_dup 3)))]
   "
 {
-   operands[2] = gen_rtx (CONST_INT, VOIDmode, INTVAL (operands[1]) & ~0xffff);
-   operands[3] = gen_rtx (CONST_INT, VOIDmode, INTVAL (operands[1]) & 0xffff);
+   operands[2] = GEN_INT (INTVAL (operands[1]) & ~0xffff);
+   operands[3] = GEN_INT (INTVAL (operands[1]) & 0xffff);
 }")
 
 (define_split
@@ -1000,8 +1000,8 @@
    (set (match_dup 0) (ior:QI (match_dup 0) (match_dup 3)))]
   "
 {
-   operands[2] = gen_rtx (CONST_INT, VOIDmode, INTVAL (operands[1]) & ~0xffff);
-   operands[3] = gen_rtx (CONST_INT, VOIDmode, INTVAL (operands[1]) & 0xffff);
+   operands[2] = GEN_INT (INTVAL (operands[1]) & ~0xffff);
+   operands[3] = GEN_INT (INTVAL (operands[1]) & 0xffff);
 }")
 
 (define_split
@@ -1022,8 +1022,8 @@
    operands[2] = gen_rtx (CONST_INT, VOIDmode,
                          (((INTVAL (operands[1]) >> 16) & 0xffff)
                           - 0x8000) ^ ~0x7fff);
-   operands[3] = gen_rtx (CONST_INT, VOIDmode, INTVAL (operands[1]) & 0xffff);
-   operands[4] = gen_rtx (CONST_INT, VOIDmode, 16);
+   operands[3] = GEN_INT (INTVAL (operands[1]) & 0xffff);
+   operands[4] = GEN_INT (16);
 }")
 
 (define_split
@@ -1043,8 +1043,8 @@
    operands[2] = gen_rtx (CONST_INT, VOIDmode,
                          (((INTVAL (operands[1]) >> 16) & 0xffff)
                           - 0x8000) ^ ~0x7fff);
-   operands[3] = gen_rtx (CONST_INT, VOIDmode, INTVAL (operands[1]) & 0xffff);
-   operands[4] = gen_rtx (CONST_INT, VOIDmode, 16);
+   operands[3] = GEN_INT (INTVAL (operands[1]) & 0xffff);
+   operands[4] = GEN_INT (16);
 }")
 
 (define_split
@@ -1063,10 +1063,9 @@
    /* Generate two's complement value of MSBs.  */
    int shift = c4x_shiftable_constant (operands[1]);
 
-   operands[2] = gen_rtx (CONST_INT, VOIDmode,
-                         (((INTVAL (operands[1]) >> shift) & 0xffff)
+   operands[2] = GEN_INT ((((INTVAL (operands[1]) >> shift) & 0xffff)
                           - 0x8000) ^ ~0x7fff);
-   operands[3] = gen_rtx (CONST_INT, VOIDmode, shift);
+   operands[3] = GEN_INT (shift);
 }")
 
 (define_split
@@ -1084,10 +1083,9 @@
    /* Generate two's complement value of MSBs.  */
    int shift = c4x_shiftable_constant (operands[1]);
 
-   operands[2] = gen_rtx (CONST_INT, VOIDmode,
-                         (((INTVAL (operands[1]) >> shift) & 0xffff)
-                          - 0x8000) ^ ~0x7fff);
-   operands[3] = gen_rtx (CONST_INT, VOIDmode, shift);
+   operands[2] = GEN_INT ((((INTVAL (operands[1]) >> shift) & 0xffff)
+                           - 0x8000) ^ ~0x7fff);
+   operands[3] = GEN_INT (shift);
 }")
 
 (define_split

diff --git a/gcc/config/sparc/sparc.c b/gcc/config/sparc/sparc.c
index 3c9e48185ad9d446e78193836941ecc38685c869..928489e9083761402eea394f7e83f37c453c1345 100644 (file)
--- a/gcc/config/sparc/sparc.c
+++ b/gcc/config/sparc/sparc.c
@@ -6292,13 +6292,15 @@ sparc_initialize_trampoline (tramp, fnaddr, cxt)
 
   emit_move_insn (gen_rtx_MEM (SImode, plus_constant (tramp, 8)),
                  expand_binop (SImode, ior_optab,
-                               expand_and (fnaddr, GEN_INT (0x3ff), NULL_RTX),
+                               expand_and (SImode, fnaddr, GEN_INT (0x3ff),
+                                           NULL_RTX),
                                GEN_INT (0x81c06000),
                                NULL_RTX, 1, OPTAB_DIRECT));
 
   emit_move_insn (gen_rtx_MEM (SImode, plus_constant (tramp, 12)),
                  expand_binop (SImode, ior_optab,
-                               expand_and (cxt, GEN_INT (0x3ff), NULL_RTX),
+                               expand_and (SImode, cxt, GEN_INT (0x3ff),
+                                           NULL_RTX),
                                GEN_INT (0x8410a000),
                                NULL_RTX, 1, OPTAB_DIRECT));
 

diff --git a/gcc/except.c b/gcc/except.c
index 606c0e64267d3b4cfdfece44b7201331562817f9..939610ffc1f54bbc510d79db32268d5e0d92e215 100644 (file)
--- a/gcc/except.c
+++ b/gcc/except.c
@@ -3088,7 +3088,7 @@ expand_builtin_extract_return_addr (addr_tree)
 
   /* First mask out any unwanted bits.  */
 #ifdef MASK_RETURN_ADDR
-  expand_and (addr, MASK_RETURN_ADDR, addr);
+  expand_and (Pmode, addr, MASK_RETURN_ADDR, addr);
 #endif
 
   /* Then adjust to find the real return address.  */

diff --git a/gcc/expmed.c b/gcc/expmed.c
index 973cbf16b5c85cd91cf0718e231c42fbac31a654..11304618aa13dfb88a9d2268ec781e2b700271d1 100644 (file)
--- a/gcc/expmed.c
+++ b/gcc/expmed.c
@@ -2717,7 +2717,7 @@ expand_mult_highpart_adjust (mode, adj_operand, op0, op1, target, unsignedp)
   tem = expand_shift (RSHIFT_EXPR, mode, op0,
                      build_int_2 (GET_MODE_BITSIZE (mode) - 1, 0),
                      NULL_RTX, 0);
-  tem = expand_and (tem, op1, NULL_RTX);
+  tem = expand_and (mode, tem, op1, NULL_RTX);
   adj_operand
     = force_operand (gen_rtx_fmt_ee (adj_code, mode, adj_operand, tem),
                     adj_operand);
@@ -2725,7 +2725,7 @@ expand_mult_highpart_adjust (mode, adj_operand, op0, op1, target, unsignedp)
   tem = expand_shift (RSHIFT_EXPR, mode, op1,
                      build_int_2 (GET_MODE_BITSIZE (mode) - 1, 0),
                      NULL_RTX, 0);
-  tem = expand_and (tem, op0, NULL_RTX);
+  tem = expand_and (mode, tem, op0, NULL_RTX);
   target = force_operand (gen_rtx_fmt_ee (adj_code, mode, adj_operand, tem),
                          target);
 
@@ -4159,23 +4159,16 @@ expand_mult_add (x, target, mult, add, mode, unsignedp)
    If TARGET is 0, a pseudo-register or constant is returned.  */
 
 rtx
-expand_and (op0, op1, target)
+expand_and (mode, op0, op1, target)
+     enum machine_mode mode;
      rtx op0, op1, target;
 {
-  enum machine_mode mode = VOIDmode;
-  rtx tem;
-
-  if (GET_MODE (op0) != VOIDmode)
-    mode = GET_MODE (op0);
-  else if (GET_MODE (op1) != VOIDmode)
-    mode = GET_MODE (op1);
+  rtx tem = 0;
 
-  if (mode != VOIDmode)
+  if (GET_MODE (op0) == VOIDmode && GET_MODE (op1) == VOIDmode)
+    tem = simplify_binary_operation (AND, mode, op0, op1);
+  if (tem == 0)
     tem = expand_binop (mode, and_optab, op0, op1, target, 0, OPTAB_LIB_WIDEN);
-  else if (GET_CODE (op0) == CONST_INT && GET_CODE (op1) == CONST_INT)
-    tem = GEN_INT (INTVAL (op0) & INTVAL (op1));
-  else
-    abort ();
 
   if (target == 0)
     target = tem;
@@ -4433,7 +4426,7 @@ emit_store_flag (target, code, op0, op1, mode, unsignedp, normalizep)
                                subtarget, normalizep == 1);
          else if (STORE_FLAG_VALUE & 1)
            {
-             op0 = expand_and (op0, const1_rtx, subtarget);
+             op0 = expand_and (compare_mode, op0, const1_rtx, subtarget);
              if (normalizep == -1)
                op0 = expand_unop (compare_mode, neg_optab, op0, op0, 0);
            }

diff --git a/gcc/expr.c b/gcc/expr.c
index f56f88640dc58f2df8902d9b783846f36f1fe623..a903b14ebb9b503bb98ad43e175bfa8bb0c3de7c 100644 (file)
--- a/gcc/expr.c
+++ b/gcc/expr.c
@@ -5143,18 +5143,16 @@ store_field (target, bitsize, bitpos, mode, exp, value_mode, unsignedp, type,
              tree count;
              enum machine_mode tmode;
 
-             if (unsignedp)
-               return expand_and (temp,
-                                  GEN_INT
-                                  (trunc_int_for_mode
-                                   (width_mask,
-                                    GET_MODE (temp) == VOIDmode
-                                    ? value_mode
-                                    : GET_MODE (temp))), NULL_RTX);
-
              tmode = GET_MODE (temp);
              if (tmode == VOIDmode)
                tmode = value_mode;
+
+             if (unsignedp)
+               return expand_and (tmode, temp,
+                                  GEN_INT (trunc_int_for_mode (width_mask,
+                                                               tmode)),
+                                  NULL_RTX);
+
              count = build_int_2 (GET_MODE_BITSIZE (tmode) - bitsize, 0);
              temp = expand_shift (LSHIFT_EXPR, tmode, temp, count, 0, 0);
              return expand_shift (RSHIFT_EXPR, tmode, temp, count, 0, 0);
@@ -6785,16 +6783,16 @@ expand_expr (exp, target, tmode, modifier)
                  {
                    HOST_WIDE_INT bitsize
                      = TREE_INT_CST_LOW (DECL_SIZE (TREE_PURPOSE (elt)));
+                   enum machine_mode imode
+                     = TYPE_MODE (TREE_TYPE (TREE_PURPOSE (elt)));
 
                    if (TREE_UNSIGNED (TREE_TYPE (TREE_PURPOSE (elt))))
                      {
                        op1 = GEN_INT (((HOST_WIDE_INT) 1 << bitsize) - 1);
-                       op0 = expand_and (op0, op1, target);
+                       op0 = expand_and (imode, op0, op1, target);
                      }
                    else
                      {
-                       enum machine_mode imode
-                         = TYPE_MODE (TREE_TYPE (TREE_PURPOSE (elt)));
                        tree count
                          = build_int_2 (GET_MODE_BITSIZE (imode) - bitsize,
                                         0);
@@ -10222,7 +10220,7 @@ do_store_flag (exp, target, mode, only_cheap)
 
       /* Put the AND last so it can combine with more things.  */
       if (bitnum != TYPE_PRECISION (type) - 1)
-       op0 = expand_and (op0, const1_rtx, subtarget);
+       op0 = expand_and (mode, op0, const1_rtx, subtarget);
 
       return op0;
     }

diff --git a/gcc/expr.h b/gcc/expr.h
index c1ee7f4e1e84f65cc634c0d46c618da72a5d9573..17f09b19a812a015303a20ebbd120bb5e4bc086c 100644 (file)
--- a/gcc/expr.h
+++ b/gcc/expr.h
@@ -309,7 +309,7 @@ int can_conditionally_move_p PARAMS ((enum machine_mode mode));
 extern rtx negate_rtx PARAMS ((enum machine_mode, rtx));
 
 /* Expand a logical AND operation.  */
-extern rtx expand_and PARAMS ((rtx, rtx, rtx));
+extern rtx expand_and PARAMS ((enum machine_mode, rtx, rtx, rtx));
 
 /* Emit a store-flag operation.  */
 extern rtx emit_store_flag PARAMS ((rtx, enum rtx_code, rtx, rtx,

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index c837e206d25419fdae83c1efe94a153721901ea7..e778ef4a6985f99ab90fbf5f99571ee01fec9426 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,7 @@
 2002-02-21  Jakub Jelinek  <jakub@redhat.com>
 
+       * gcc.dg/20020220-1.c: New test.
+
        * gcc.dg/20020220-2.c: New test.
 
 2002-02-20  Alexandre Oliva  <aoliva@redhat.com>

diff --git a/gcc/testsuite/gcc.dg/20020220-1.c b/gcc/testsuite/gcc.dg/20020220-1.c
new file mode 100644 (file)
index 0000000..aa948aa
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/20020220-1.c
@@ -0,0 +1,19 @@
+/* PR c++/4574
+   This testcase ICEd because expand_and did not handle VOIDmode
+   CONST_DOUBLE arguments.  */
+/* { dg-do compile } */
+/* { dg-options "-w" } */
+
+struct A {
+  unsigned long long b : 8;
+  unsigned long long c : 18;
+};
+
+int main()
+{
+  struct A a;
+  long long l;
+
+  l = a.c = 0x123456789aULL;
+  return 0;
+}