[multiple changes]

2016-01-23  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

	PR fortran/69397
	PR fortran/68442
	* interface.c (gfc_arglist_matches_symbol): Replace assert with
	a return false if not a procedure.
	* resolve.c (resolve_generic_f): Test if we are resolving an
	initialization expression and adjust error message accordingly.

2016-01-24  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

	PR fortran/69397
	PR fortran/68442
	* gfortran.dg/interface_38.f90: New test.
	* gfortran.dg/interface_39.f90: New test.

From-SVN: r232780

diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 414991bc67cef3183aac1bc0a151458acb2b7ae2..5853ddf374c42e1dfff6b2d155e1ed7499909aaf 100644 (file)
--- a/gcc/fortran/ChangeLog
+++ b/gcc/fortran/ChangeLog
@@ -1,3 +1,12 @@
+2016-01-23  Jerry DeLisle  <jvdelisle@gcc.gnu.org>
+
+       PR fortran/69397
+       PR fortran/68442
+       * interface.c (gfc_arglist_matches_symbol): Replace assert with
+       a return false if not a procedure.
+       * resolve.c (resolve_generic_f): Test if we are resolving an
+       initialization expression and adjust error message accordingly.
+
 2016-01-24  Thomas Koenig  <tkoenig@gcc.gnu.org>
 
        PR fortran/66094

diff --git a/gcc/fortran/interface.c b/gcc/fortran/interface.c
index f5e8d0d7bbe63ab5d4232bbbc7232f5e64370003..5c66c6ef31cfee9d07ed136187afd1db307f4e38 100644 (file)
--- a/gcc/fortran/interface.c
+++ b/gcc/fortran/interface.c
@@ -3506,7 +3506,8 @@ gfc_arglist_matches_symbol (gfc_actual_arglist** args, gfc_symbol* sym)
   gfc_formal_arglist *dummy_args;
   bool r;
 
-  gcc_assert (sym->attr.flavor == FL_PROCEDURE);
+  if (sym->attr.flavor != FL_PROCEDURE)
+    return false;
 
   dummy_args = gfc_sym_get_dummy_args (sym);
 

diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
index 64d59ceef17cd46d471a73eca5fda926d9fd1b28..8752fd4693b928fcdf57a2bc57943ad547d6c22b 100644 (file)
--- a/gcc/fortran/resolve.c
+++ b/gcc/fortran/resolve.c
@@ -2565,8 +2565,13 @@ generic:
      that possesses a matching interface.  14.1.2.4  */
   if (sym  && !intr && !gfc_is_intrinsic (sym, 0, expr->where))
     {
-      gfc_error ("There is no specific function for the generic %qs "
-                "at %L", expr->symtree->n.sym->name, &expr->where);
+      if (gfc_init_expr_flag)
+       gfc_error ("Function %qs in initialization expression at %L "
+                  "must be an intrinsic function",
+                  expr->symtree->n.sym->name, &expr->where);
+      else
+       gfc_error ("There is no specific function for the generic %qs "
+                  "at %L", expr->symtree->n.sym->name, &expr->where);
       return false;
     }
 

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 95f49032225d7161a79164924fb6ffc6d9f1c27f..30540554b733a2f971a90cb78f3fa7e01497e198 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2016-01-24  Jerry DeLisle  <jvdelisle@gcc.gnu.org>
+
+       PR fortran/69397
+       PR fortran/68442
+       * gfortran.dg/interface_38.f90: New test.
+       * gfortran.dg/interface_39.f90: New test.
+       
 2016-01-24  Patrick Palka  <ppalka@gcc.gnu.org>
 
        Revert:

diff --git a/gcc/testsuite/gfortran.dg/interface_38.f90 b/gcc/testsuite/gfortran.dg/interface_38.f90
new file mode 100644 (file)
index 0000000..d8f42ee
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/interface_38.f90
@@ -0,0 +1,16 @@
+! { dg-do compile }
+! PR69397
+program p
+   interface f
+      procedure f1 ! { dg-error "neither function nor subroutine" }
+      !... more
+   end interface
+   integer, allocatable :: z
+   print *, f(z) ! { dg-error "no specific function" }
+contains
+   integer function f2 (x)
+      integer, allocatable :: x
+      f2 = 1
+   end
+end
+

diff --git a/gcc/testsuite/gfortran.dg/interface_39.f90 b/gcc/testsuite/gfortran.dg/interface_39.f90
new file mode 100644 (file)
index 0000000..0d6a38e
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/interface_39.f90
@@ -0,0 +1,14 @@
+! { dg-do compile }
+! PR68442
+module m
+   interface gkind
+      procedure g
+   end interface
+contains
+   subroutine f(x)
+      character(kind=gkind()) :: x ! { dg-error "must be an intrinsic" }
+   end
+   integer function g()
+      g = 1
+   end
+end