PR 47375 getlog thread safety

From-SVN: r169243

diff --git a/libgfortran/ChangeLog b/libgfortran/ChangeLog
index 6aa03e640eac5b0806d56d2062848db56fe5451a..dc53e87dd2d6b3a8ac9d64e1d16b4d08555b6ecc 100644 (file)
--- a/libgfortran/ChangeLog
+++ b/libgfortran/ChangeLog
@@ -1,3 +1,11 @@
+2011-01-25  Janne Blomqvist  <jb@gcc.gnu.org>
+
+       PR libfortran/47375
+       * config.h.in: Regenerated.
+       * configure: Regenerated.
+       * configure.ac: Add check for getpwuid_r.
+       * intrinsics/getlog.c (getlog): Use getpwuid_r() if available.
+
 2011-01-22  Janne Blomqvist  <jb@gcc.gnu.org>
 
        PR libfortran/46267

diff --git a/libgfortran/config.h.in b/libgfortran/config.h.in
index c5a2d8a1dc111a19f262786f061e4eda18d9e2fa..0701c63916c6c14b12c5c7a9c86877777e50920b 100644 (file)
--- a/libgfortran/config.h.in
+++ b/libgfortran/config.h.in
@@ -462,6 +462,9 @@
 /* Define to 1 if you have the `getpwuid' function. */
 #undef HAVE_GETPWUID
 
+/* Define to 1 if you have the `getpwuid_r' function. */
+#undef HAVE_GETPWUID_R
+
 /* Define to 1 if you have the `getrlimit' function. */
 #undef HAVE_GETRLIMIT
 

diff --git a/libgfortran/configure b/libgfortran/configure
index ec63cdb1e9109f320946816daa16a1f38f2f5a18..2cbf6546307b80569840520a218cb3893027f172 100755 (executable)
--- a/libgfortran/configure
+++ b/libgfortran/configure
@@ -15636,7 +15636,7 @@ _ACEOF
 fi
 done
 
-for ac_func in localtime_r gmtime_r strerror_r
+for ac_func in localtime_r gmtime_r strerror_r getpwuid_r
 do :
   as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
 ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"

diff --git a/libgfortran/configure.ac b/libgfortran/configure.ac
index 4f137e43253f33b03a92b38f440d725a3c6221c3..9b91f9af525c31a23317013ae9492acf9e312127 100644 (file)
--- a/libgfortran/configure.ac
+++ b/libgfortran/configure.ac
@@ -249,7 +249,7 @@ AC_CHECK_FUNCS(chdir strerror getlogin gethostname kill link symlink perror)
 AC_CHECK_FUNCS(sleep time ttyname signal alarm ctime clock access fork execl)
 AC_CHECK_FUNCS(wait setmode execvp pipe dup2 close fdopen strcasestr getrlimit)
 AC_CHECK_FUNCS(gettimeofday stat fstat lstat getpwuid vsnprintf dup getcwd)
-AC_CHECK_FUNCS(localtime_r gmtime_r strerror_r)
+AC_CHECK_FUNCS(localtime_r gmtime_r strerror_r getpwuid_r)
 
 # Check for glibc backtrace functions
 AC_CHECK_FUNCS(backtrace backtrace_symbols)

diff --git a/libgfortran/intrinsics/getlog.c b/libgfortran/intrinsics/getlog.c
index e75aa1cb7d26a2a730d230d49f952ccdb055adc3..baacdf0609f94f48adc412511da9a8d72b59f0b8 100644 (file)
--- a/libgfortran/intrinsics/getlog.c
+++ b/libgfortran/intrinsics/getlog.c
@@ -1,8 +1,8 @@
 /* Implementation of the GETLOG g77 intrinsic.
-   Copyright (C) 2005, 2007, 2009 Free Software Foundation, Inc.
+   Copyright (C) 2005, 2007, 2009, 2011 Free Software Foundation, Inc.
    Contributed by François-Xavier Coudert <coudert@clipper.ens.fr>
 
-This file is part of the GNU Fortran 95 runtime library (libgfortran).
+This file is part of the GNU Fortran runtime library (libgfortran).
 
 Libgfortran is free software; you can redistribute it and/or
 modify it under the terms of the GNU General Public
@@ -75,7 +75,22 @@ PREFIX(getlog) (char * login, gfc_charlen_type login_len)
 
   memset (login, ' ', login_len); /* Blank the string.  */
 
-#if defined(HAVE_GETPWUID) && defined(HAVE_GETEUID)
+#if defined(HAVE_GETPWUID_R) && defined(HAVE_GETEUID)
+  struct passwd pwd;
+  struct passwd *result;
+  char *buf;
+  int err;
+  /* To be pedantic, buflen should be determined by
+     sysconf(_SC_GETPW_R_SIZE_MAX), which is 1024 on some tested
+     targets; we do something simple in case the target doesn't
+     support sysconf.  */
+  static const size_t buflen = 1024;
+  buf = get_mem (buflen);
+  err = getpwuid_r (geteuid (), &pwd, buf, buflen, &result);
+  if (err != 0 || result == NULL)
+    goto cleanup;
+  p = pwd.pw_name;
+#elif defined(HAVE_GETPWUID) && defined(HAVE_GETEUID)
   {
     struct passwd *pw = getpwuid (geteuid ());
     if (pw)
@@ -83,20 +98,22 @@ PREFIX(getlog) (char * login, gfc_charlen_type login_len)
     else
       return;
   }
-#else
-# ifdef HAVE_GETLOGIN
+#elif HAVE_GETLOGIN
   p = getlogin();
 # else
   return;
-# endif
 #endif
 
   if (p == NULL)
-    return;
+    goto cleanup;
 
   p_len = strlen (p);
   if (login_len < p_len)
-    memcpy (login, p, login_len);
-  else
-    memcpy (login, p, p_len);
+    p_len = login_len;
+  memcpy (login, p, p_len);
+
+ cleanup:
+#ifdef HAVE_GETPWUID_R
+  free (buf);
+#endif
 }