]> gcc.gnu.org Git - gcc.git/commit
powerpc: Fix up *branch_anddi3_dot for -m32 -mpowerpc64 [PR109566]
authorJakub Jelinek <jakub@redhat.com>
Tue, 25 Apr 2023 12:20:51 +0000 (14:20 +0200)
committerJakub Jelinek <jakub@redhat.com>
Tue, 25 Apr 2023 12:37:16 +0000 (14:37 +0200)
commitfb4e50a7c1cdd14e8f06421c642837292c9d8dee
treed707d605a837ac486f4cbbff809e7f5b75b64feb
parent4fee426ce03e616a4db129edca30efa1267d1503
powerpc: Fix up *branch_anddi3_dot for -m32 -mpowerpc64 [PR109566]

The following testcase reduced from newlib ICEs on powerpc-linux,
with -O2 -m32 -mpowerpc64 since r12-6433 PR102239 optimization was
added and on the original testcase since some ranger improvements in
GCC 13 made it no longer latent on newlib.
The problem is that the *branch_anddi3_dot define_insn_and_split
relies on the *rotldi3_mask_dot define_insn_and_split being recognized
during splitting.  The rs6000_is_valid_rotate_dot_mask function checks whether
the mask is a CONST_INT which is a valid mask, but *rotl<mode>3_mask_dot in
addition to checking that it is a valid mask also has
  (<MODE>mode == Pmode || UINTVAL (operands[3]) <= 0x7fffffff)
test in the condition.  For TARGET_64BIT that doesn't add any further
requirements, but for !TARGET_64BIT && TARGET_POWERPC64 if the AND
second operand is larger than INT_MAX it will not be recognized.

The rs6000_is_valid_rotate_dot_mask function is used solely in one spot,
condition of *branch_anddi3_dot, so the following patch adjusts it
to check for that as well.

2023-04-25  Jakub Jelinek  <jakub@redhat.com>

PR target/109566
* config/rs6000/rs6000.cc (rs6000_is_valid_rotate_dot_mask): For
!TARGET_64BIT, don't return true if UINTVAL (mask) << (63 - nb)
is larger than signed int maximum.

* gcc.target/powerpc/pr109566.c: New test.

(cherry picked from commit 97f8f2d0a0384d377ca46da88495f9a3d18d4415)
gcc/config/rs6000/rs6000.cc
gcc/testsuite/gcc.target/powerpc/pr109566.c [new file with mode: 0644]
This page took 0.070279 seconds and 5 git commands to generate.