]> gcc.gnu.org Git - gcc.git/commit
Merge #631
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>
Tue, 17 Aug 2021 08:01:46 +0000 (08:01 +0000)
committerGitHub <noreply@github.com>
Tue, 17 Aug 2021 08:01:46 +0000 (08:01 +0000)
commitd9082b50a98168b766cfc5136f50a3497c14897d
tree43d75121ca9c9b69b3baf9ca04271d39b73e3b0b
parent52c1cdc9c63baeb090680daf6762c02362f2c6cd
parent5b229ddbf41c9e74fcce930c26101c1d34a5c9d1
Merge #631

631: Use builtin bool instead of creating new bool types for ComparisonExpr r=dkm a=dkm

From Mark Wielaard : https://gcc.gnu.org/pipermail/gcc-rust/2021-August/000141.html

> The TypeCheckExpr creates a new TyTy::BoolType for a
> ComparisonExpr. This new BoolType is unknown to TyTyResolveCompile
> which causes a crash when trying to compile the inferred new
> BoolType. Resolve this by looking up the builtin bool type.
> The new "bools_eq.rs" testcase uses several bools which show
> this issue.
>
> Also the lhs and rhs types need to be compatible, but don't
> need to be bool type themselves. So don't append the reference
> to the inferred type. The existing "ifunaryexpr.rs" testcase
> will fail without this fix.

Co-authored-by: Mark Wielaard <mark@klomp.org>
This page took 0.055362 seconds and 5 git commands to generate.