]> gcc.gnu.org Git - gcc.git/commit
c++: Allow mixing GNU/std-style attributes [PR69585]
authorMarek Polacek <polacek@redhat.com>
Thu, 2 Jun 2022 19:44:20 +0000 (15:44 -0400)
committerMarek Polacek <polacek@redhat.com>
Sat, 4 Jun 2022 13:57:28 +0000 (09:57 -0400)
commitaec868578d8515763d75693c1fdfbc30ff0a1e68
tree6d8b399e71c72fe20dd46dc97052f3a8faac6179
parented6fd2aed58f2cca99f15331bf68999c0e6df370
c++: Allow mixing GNU/std-style attributes [PR69585]

cp_parser_attributes_opt doesn't accept GNU attributes followed by
[[]] attributes and vice versa; only a sequence of attributes of the
same kind.  That causes grief for code like:

  struct __attribute__ ((may_alias)) alignas (2) struct S { };

or

  #define EXPORT __attribute__((visibility("default")))
  struct [[nodiscard]] EXPORT F { };

It doesn't seem to a documented restriction, so this patch fixes the
problem.

However, the patch does not touch the C FE.  The C FE doesn't have
a counterpart to C++'s cp_parser_attributes_opt -- it only has
c_parser_transaction_attributes (which parses both GNU and [[]]
attributes), but that's TM-specific.  The C FE seems to use either
c_parser_gnu_attributes or c_parser_std_attribute_specifier_sequence.
As a consequence, this works:

  [[maybe_unused]] __attribute__((deprecated)) void f2 ();

but this doesn't:

  __attribute__((deprecated)) [[maybe_unused]] void f1 ();

I'm not sure what, if anything, should be done about this.

PR c++/102399
PR c++/69585

gcc/cp/ChangeLog:

* parser.cc (cp_parser_attributes_opt): Accept GNU attributes
followed by [[]] attributes and vice versa.

gcc/testsuite/ChangeLog:

* g++.dg/ext/attrib65.C: New test.
* g++.dg/ext/attrib66.C: New test.
* g++.dg/ext/attrib67.C: New test.
gcc/cp/parser.cc
gcc/testsuite/g++.dg/ext/attrib65.C [new file with mode: 0644]
gcc/testsuite/g++.dg/ext/attrib66.C [new file with mode: 0644]
gcc/testsuite/g++.dg/ext/attrib67.C [new file with mode: 0644]
This page took 0.056816 seconds and 5 git commands to generate.