]> gcc.gnu.org Git - gcc.git/commit
c++: ICE with template code in constexpr [PR104284]
authorMarek Polacek <polacek@redhat.com>
Thu, 17 Mar 2022 18:39:37 +0000 (14:39 -0400)
committerMarek Polacek <polacek@redhat.com>
Thu, 24 Mar 2022 20:59:57 +0000 (16:59 -0400)
commit9fdac7e16c940fb6264e6ddaf99c761f1a64a054
tree33fae8fdc94ade66fe5fc55a1204b17dfbeb4159
parent346ab5a54a831ad9c78afcbd8dfe98e0e07e3070
c++: ICE with template code in constexpr [PR104284]

Since r9-6073 cxx_eval_store_expression preevaluates the value to
be stored, and that revealed a crash where a template code (here,
code=IMPLICIT_CONV_EXPR) leaks into cxx_eval*.

It happens because we're performing build_vec_init while processing
a template, which calls get_temp_regvar which creates an INIT_EXPR.
This INIT_EXPR's RHS contains an rvalue conversion so we create an
IMPLICIT_CONV_EXPR.  Its operand is not type-dependent and the whole
INIT_EXPR is not type-dependent.  So we call build_non_dependent_expr
which, with -fchecking=2, calls fold_non_dependent_expr.  At this
point the expression still has an IMPLICIT_CONV_EXPR, which ought to
be handled in instantiate_non_dependent_expr_internal.  However,
tsubst_copy_and_build doesn't handle INIT_EXPR; it will just call
tsubst_copy which does nothing when args is null.  So we fail to
replace the IMPLICIT_CONV_EXPR and ICE.

The problem is that we call build_vec_init in a template in the
first place.  We can avoid doing so by checking p_t_d before
calling build_aggr_init in check_initializer.

PR c++/104284

gcc/cp/ChangeLog:

* decl.cc (check_initializer): Don't call build_aggr_init in
a template.

gcc/testsuite/ChangeLog:

* g++.dg/cpp1y/constexpr-104284-1.C: New test.
* g++.dg/cpp1y/constexpr-104284-2.C: New test.
* g++.dg/cpp1y/constexpr-104284-3.C: New test.
* g++.dg/cpp1y/constexpr-104284-4.C: New test.
gcc/cp/decl.cc
gcc/testsuite/g++.dg/cpp1y/constexpr-104284-1.C [new file with mode: 0644]
gcc/testsuite/g++.dg/cpp1y/constexpr-104284-2.C [new file with mode: 0644]
gcc/testsuite/g++.dg/cpp1y/constexpr-104284-3.C [new file with mode: 0644]
gcc/testsuite/g++.dg/cpp1y/constexpr-104284-4.C [new file with mode: 0644]
This page took 0.064777 seconds and 5 git commands to generate.