]> gcc.gnu.org Git - gcc.git/commit
libstdc++: Check lengths first in operator== for basic_string [PR62187]
authorJonathan Wakely <jwakely@redhat.com>
Tue, 14 Jun 2022 15:19:32 +0000 (16:19 +0100)
committerJonathan Wakely <jwakely@redhat.com>
Tue, 14 Jun 2022 20:07:48 +0000 (21:07 +0100)
commit6abe341558abec40c9c44d76e7fb4fb3978e894b
tree70cced94b085f2c16a8eae9081e68db42407f5d1
parent1b65779f46f16b4fffd0591f5e58722c1e7cde8d
libstdc++: Check lengths first in operator== for basic_string [PR62187]

As confirmed by LWG 2852, the calls to traits_type::compare do not need
to be obsvervable, so we can make operator== compare string lengths
first and return immediately for non-equal lengths. This avoids doing a
slow string comparison for "abc...xyz" == "abc...xy". Previously we only
did this optimization for std::char_traits<char>, but we can enable it
unconditionally thanks to LWG 2852.

For comparisons with a const char* we can call traits_type::length right
away to do the same optimization. That strlen call can be folded away
for constant arguments, making it very efficient.

For the pre-C++20 operator== and operator!= overloads we can swap the
order of the arguments to take advantage of the operator== improvements.

libstdc++-v3/ChangeLog:

PR libstdc++/62187
* include/bits/basic_string.h (operator==): Always compare
lengths before checking string contents.
[!__cpp_lib_three_way_comparison] (operator==, operator!=):
Reorder arguments.
libstdc++-v3/include/bits/basic_string.h
This page took 0.050351 seconds and 5 git commands to generate.